util: Make pakfire_string_replace more robust on invalid inputs

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>

diff --git a/src/libpakfire/util.c b/src/libpakfire/util.c
index 70c04da6ff6db7b9553dfc743906eacec2046eb7..fe6ba5be842436a31211030b71a39fed1ab22cfc 100644 (file)
--- a/src/libpakfire/util.c
+++ b/src/libpakfire/util.c
@@ -74,6 +74,16 @@ PAKFIRE_EXPORT int pakfire_string_partition(
 
 PAKFIRE_EXPORT char* pakfire_string_replace(
                const char* s, const char* pattern, const char* repl) {
+       // Return NULL on no input or no pattern
+       if (!s || !pattern) {
+               errno = EINVAL;
+               return NULL;
+       }
+
+       // Replace with nothing when repl is NULL
+       if (!repl)
+               repl = "";
+
        char* result = NULL;
        const char** cache = NULL;
        unsigned int count = 0;