FS-8316 resolving the build warnings in the modules too

diff --git a/src/mod/applications/mod_conference/conference_member.c b/src/mod/applications/mod_conference/conference_member.c
index 8d5af7fa628fcf9c622aa6a008a64cdb4221dbfe..5d60dcd16c0ac4c14dcbb0b769e9fa431333a09d 100644 (file)
--- a/src/mod/applications/mod_conference/conference_member.c
+++ b/src/mod/applications/mod_conference/conference_member.c
@@ -1422,7 +1422,7 @@ switch_status_t conference_member_say(conference_member_t *member, char *text, u
                fp = switch_core_strdup(pool, text);
                switch_assert(fp);
 
-               if (!switch_event_create_brackets(fp, '{', '}', ',', &params, &new_fp, SWITCH_FALSE) == SWITCH_STATUS_SUCCESS) {
+               if (switch_event_create_brackets(fp, '{', '}', ',', &params, &new_fp, SWITCH_FALSE) != SWITCH_STATUS_SUCCESS) {
                        new_fp = fp;
                }
 

diff --git a/src/mod/applications/mod_conference/mod_conference.c b/src/mod/applications/mod_conference/mod_conference.c
index 7ae047ad36e2c8070fedfbf0a4d929e96a74a3c3..963ae9aa1585f4dc4ba798ae1471242e9907cd2b 100644 (file)
--- a/src/mod/applications/mod_conference/mod_conference.c
+++ b/src/mod/applications/mod_conference/mod_conference.c
@@ -899,7 +899,7 @@ switch_status_t conference_say(conference_obj_t *conference, const char *text, u
                fp = switch_core_strdup(pool, text);
                switch_assert(fp);
 
-               if (!switch_event_create_brackets(fp, '{', '}', ',', &params, &new_fp, SWITCH_FALSE) == SWITCH_STATUS_SUCCESS) {
+               if (switch_event_create_brackets(fp, '{', '}', ',', &params, &new_fp, SWITCH_FALSE) != SWITCH_STATUS_SUCCESS) {
                        new_fp = fp;
                }
 

diff --git a/src/mod/applications/mod_enum/mod_enum.c b/src/mod/applications/mod_enum/mod_enum.c
index 42126f30094a09c683299c38795d52159228788a..efa3fe31258468ae31b91d3af265581c4855d79d 100644 (file)
--- a/src/mod/applications/mod_enum/mod_enum.c
+++ b/src/mod/applications/mod_enum/mod_enum.c
@@ -838,7 +838,7 @@ SWITCH_STANDARD_API(enum_function)
 
                }
 
-               if (!enum_lookup(root, dest, &results, NULL, session) == SWITCH_STATUS_SUCCESS) {
+               if (enum_lookup(root, dest, &results, NULL, session) != SWITCH_STATUS_SUCCESS) {
                        stream->write_function(stream, "No Match!\n");
                        return SWITCH_STATUS_SUCCESS;
                }

diff --git a/src/mod/endpoints/mod_skinny/skinny_server.c b/src/mod/endpoints/mod_skinny/skinny_server.c
index 28b68ab8fddffd5a2f9b0924999a7697607a8ad6..497bf68b84820f81b2202942ad99c4067ec681dc 100644 (file)
--- a/src/mod/endpoints/mod_skinny/skinny_server.c
+++ b/src/mod/endpoints/mod_skinny/skinny_server.c
@@ -149,13 +149,13 @@ switch_status_t skinny_create_incoming_session(listener_t *listener, uint32_t *l
                goto error;
        }
        /* First create the caller profile in the patterns Dialplan */
-       if (!(tech_pvt->caller_profile = switch_caller_profile_new(switch_core_session_get_pool(nsession),
+       if ((tech_pvt->caller_profile = switch_caller_profile_new(switch_core_session_get_pool(nsession),
                                        NULL, listener->profile->patterns_dialplan, 
                                        button->displayname, button->shortname, 
                                        listener->remote_ip, NULL, NULL, NULL,
                                        "skinny" /* modname */,
                                        listener->profile->patterns_context, 
-                                       "")) != 0) {
+                                       "")) == NULL) {
                skinny_log_ls_msg(listener, nsession, SWITCH_LOG_CRIT, "Error Creating Session caller profile\n");
                goto error;
        }