]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
Revert "io_uring: ensure deferred completions are posted for multishot"
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 17 Jun 2025 13:42:12 +0000 (15:42 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 27 Jun 2025 10:07:24 +0000 (11:07 +0100)
This reverts commit b82c386898f7b00cb49abe3fbd622017aaa61230 which is
commit 687b2bae0efff9b25e071737d6af5004e6e35af5 upstream.

Jens writes:
There's some missing dependencies that makes this not work
right, I'll bring it back in a series instead.

Link: https://lore.kernel.org/r/313f2335-626f-4eea-8502-d5c3773db35a@kernel.dk
Reported-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
io_uring/io_uring.c

index ad462724246a7b35a3e841866f784e43d3cf18c9..abefc334cf7d1510047350d65058f705777ad51a 100644 (file)
@@ -820,14 +820,6 @@ bool io_post_aux_cqe(struct io_ring_ctx *ctx,
 {
        bool filled;
 
-       /*
-        * If multishot has already posted deferred completions, ensure that
-        * those are flushed first before posting this one. If not, CQEs
-        * could get reordered.
-        */
-       if (!wq_list_empty(&ctx->submit_state.compl_reqs))
-               __io_submit_flush_completions(ctx);
-
        io_cq_lock(ctx);
        filled = io_fill_cqe_aux(ctx, user_data, res, cflags, allow_overflow);
        io_cq_unlock_post(ctx);