libcgroup: Some cgexec cleanups

From: Vivek Goyal <vgoyal@redhat.com>

cgexec cleanup based on balbir's feedback.

Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
Signed-off-by: Dhaval Giani <dhaval@linux.vnet.ibm.com>
git-svn-id: https://libcg.svn.sourceforge.net/svnroot/libcg/trunk@160 4f4bb910-9a46-0410-90c8-c897d4f1cd53

diff --git a/cgexec.c b/cgexec.c
index d91207f1e18b363d843aebbe5061d0d2355585f3..9558bca081552de45848efc8bb2de06879a5b4a8 100644 (file)
--- a/cgexec.c
+++ b/cgexec.c
@@ -28,8 +28,6 @@
 #include <sys/stat.h>
 #include <sys/types.h>
 
-#define CG_HIER_MAX    CG_CONTROLLER_MAX
-#define CG_CONT_NAMELEN_MAX    128
 
 struct cgroup_data {
        char path[FILENAME_MAX];
@@ -84,14 +82,12 @@ int parse_cgroup_data(struct cgroup_data *cdptr[], char *optarg)
                        temp = strtok(NULL, ",");
 
                if (temp) {
-                       cdptr[i]->controllers[j] =
-                                       (char *) malloc(strlen(temp) + 1);
+                       cdptr[i]->controllers[j] = strdup(temp);
                        if (!cdptr[i]->controllers[j]) {
                                free(cdptr[i]);
                                fprintf(stderr, "%s\n", strerror(errno));
                                return -1;
-                       } else
-                               strcpy(cdptr[i]->controllers[j], temp);
+                       }
                }
                j++;
        } while (temp);