]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: Error out on invalid pci-root controller model name
authorAndrea Bolognani <abologna@redhat.com>
Fri, 9 Feb 2018 15:56:13 +0000 (16:56 +0100)
committerAndrea Bolognani <abologna@redhat.com>
Fri, 9 Feb 2018 17:00:53 +0000 (18:00 +0100)
This is a hard error, and should be handled as such.
Introduced in 24614760228b.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: John Ferlan <jferlan@redhat.com>
src/qemu/qemu_domain.c

index 16833474a10215a1769cc3689df7e770d2c43bc0..178ec24ae7e0cd4cc3b488cfb100e77b629104ae 100644 (file)
@@ -4446,7 +4446,7 @@ qemuDomainDeviceDefValidateControllerPCI(const virDomainControllerDef *controlle
                            _("PCI controller model name '%s' is not valid "
                              "for a pci-root"),
                            modelName);
-            return 0;
+            return -1;
         }
 
         if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_SPAPR_PCI_HOST_BRIDGE)) {