]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commitdiff
Fix broken example with @declared_attr.cascading
authoraplatkouski <5857672+aplatkouski@users.noreply.github.com>
Sun, 7 Jun 2020 13:05:05 +0000 (16:05 +0300)
committeraplatkouski <5857672+aplatkouski@users.noreply.github.com>
Tue, 16 Jun 2020 18:26:52 +0000 (21:26 +0300)
Signed-off-by: aplatkouski <5857672+aplatkouski@users.noreply.github.com>
doc/build/changelog/migration_10.rst
lib/sqlalchemy/ext/declarative/api.py

index e31b621fe66b6af3659e2ede3749863f95adbb00..b784036c6f4c02c48e6d98ace84842faade32628 100644 (file)
@@ -167,7 +167,7 @@ applied::
         @declared_attr.cascading
         def id(cls):
             if has_inherited_table(cls):
-                return Column(ForeignKey('myclass.id'), primary_key=True)
+                return Column('some_id', ForeignKey('myclass.id'))
             else:
                 return Column(Integer, primary_key=True)
 
index 65d100bc7580ee4c32dc37723418b9790d2a6465..2d2155abc5f5b20872646ecd8c9f6f380c37a7bd 100644 (file)
@@ -229,8 +229,7 @@ class declared_attr(interfaces._MappedAttribute, property):
                 @declared_attr.cascading
                 def id(cls):
                     if has_inherited_table(cls):
-                        return Column(
-                            ForeignKey('myclass.id'), primary_key=True)
+                        return Column('some_id', ForeignKey('myclass.id'))
                     else:
                         return Column(Integer, primary_key=True)