xfrm: drop SA reference in xfrm_state_update if dir doesn't match

[ Upstream commit 8d2a2a49c30f67a480fa9ed25e08436a446f057e ]

We're not updating x1, but we still need to put() it.

Fixes: a4a87fa4e96c ("xfrm: Add Direction to the SA in or out")
Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/net/xfrm/xfrm_state.c b/net/xfrm/xfrm_state.c
index 1e2f5ecd63248bf3607459d564694bab70bc7e8e..f8cb033f102edf8b00c3afdc582d63d4beb0ac81 100644 (file)
--- a/net/xfrm/xfrm_state.c
+++ b/net/xfrm/xfrm_state.c
@@ -2117,14 +2117,18 @@ int xfrm_state_update(struct xfrm_state *x)
        }
 
        if (x1->km.state == XFRM_STATE_ACQ) {
-               if (x->dir && x1->dir != x->dir)
+               if (x->dir && x1->dir != x->dir) {
+                       to_put = x1;
                        goto out;
+               }
 
                __xfrm_state_insert(x);
                x = NULL;
        } else {
-               if (x1->dir != x->dir)
+               if (x1->dir != x->dir) {
+                       to_put = x1;
                        goto out;
+               }
        }
        err = 0;