]> git.ipfire.org Git - thirdparty/patchwork.git/commitdiff
REST: Make single-use function a staticmethod
authorStephen Finucane <stephen@that.guru>
Sat, 6 Jan 2018 22:43:56 +0000 (22:43 +0000)
committerStephen Finucane <stephen@that.guru>
Wed, 10 Jan 2018 00:09:08 +0000 (00:09 +0000)
Signed-off-by: Stephen Finucane <stephen@that.guru>
patchwork/api/patch.py

index 1922cf5b8e41ea088c85374dbe85de4f1e8ebbf1..115feffae74b64385a1bbe80fd910b6fc866da68 100644 (file)
@@ -38,10 +38,6 @@ from patchwork.models import State
 from patchwork.parser import clean_subject
 
 
-def format_state_name(state):
-    return ' '.join(state.split('-'))
-
-
 class StateField(RelatedField):
     """Avoid the need for a state endpoint.
 
@@ -58,13 +54,17 @@ class StateField(RelatedField):
                             '{data_type}.'),
     }
 
+    @staticmethod
+    def format_state_name(state):
+        return ' '.join(state.split('-'))
+
     def to_internal_value(self, data):
         try:
-            data = format_state_name(data)
+            data = self.format_state_name(data)
             return self.get_queryset().get(name__iexact=data)
         except State.DoesNotExist:
             self.fail('invalid_choice', name=data, choices=', '.join([
-                format_state_name(x.name) for x in self.get_queryset()]))
+                self.format_state_name(x.name) for x in self.get_queryset()]))
         except (TypeError, ValueError):
             self.fail('incorrect_type', data_type=type(data).__name__)