]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemuBuildHotpluggableCPUProps: use VIR_RETURN_PTR
authorJán Tomko <jtomko@redhat.com>
Tue, 20 Aug 2019 10:40:09 +0000 (12:40 +0200)
committerJán Tomko <jtomko@redhat.com>
Thu, 22 Aug 2019 09:27:31 +0000 (11:27 +0200)
This lets us get rid of the error label.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/qemu/qemu_command.c

index 1b5cde6ec77936810801b4a5d75dcc7e642ab726..5e05916b2308abcede91e6e27480ebb621d66699 100644 (file)
@@ -11047,33 +11047,29 @@ virJSONValuePtr
 qemuBuildHotpluggableCPUProps(const virDomainVcpuDef *vcpu)
 {
     qemuDomainVcpuPrivatePtr vcpupriv = QEMU_DOMAIN_VCPU_PRIVATE(vcpu);
-    virJSONValuePtr ret = NULL;
+    VIR_AUTOPTR(virJSONValue) ret = NULL;
 
     if (virJSONValueObjectCreate(&ret, "s:driver", vcpupriv->type,
                                        "s:id", vcpupriv->alias, NULL) < 0)
-        goto error;
+        return NULL;
 
     if (vcpupriv->socket_id != -1 &&
         virJSONValueObjectAdd(ret, "i:socket-id", vcpupriv->socket_id, NULL) < 0)
-        goto error;
+        return NULL;
 
     if (vcpupriv->core_id != -1 &&
         virJSONValueObjectAdd(ret, "i:core-id", vcpupriv->core_id, NULL) < 0)
-        goto error;
+        return NULL;
 
     if (vcpupriv->thread_id != -1 &&
         virJSONValueObjectAdd(ret, "i:thread-id", vcpupriv->thread_id, NULL) < 0)
-        goto error;
+        return NULL;
 
     if (vcpupriv->node_id != -1 &&
         virJSONValueObjectAdd(ret, "i:node-id", vcpupriv->node_id, NULL) < 0)
-        goto error;
-
-    return ret;
+        return NULL;
 
- error:
-    virJSONValueFree(ret);
-    return NULL;
+    VIR_RETURN_PTR(ret);
 }