Apply suggestions from code review

Co-authored-by: Kevin P. Fleming <kpfleming@users.noreply.github.com>

diff --git a/pdns/recursordist/rec-xfr.hh b/pdns/recursordist/rec-xfr.hh
index b6910610d2723b63caff063ca8af5597a5bcf587..96ce86d3ac395bc50d6165930618d2064d73c1b3 100644 (file)
--- a/pdns/recursordist/rec-xfr.hh
+++ b/pdns/recursordist/rec-xfr.hh
@@ -38,7 +38,7 @@ class DNSName;
 class SOARecordContent;
 struct FWCatz;
 
-// Please make sure that the struct below only contains value types since they are used as parameters in a thread ct
+// All members of this struct must be copyable, as they are used as parameters in a thread constructor
 struct ZoneXFRParams
 {
   std::string name;
@@ -103,7 +103,7 @@ struct FWCatz
 class ZoneXFR
 {
 public:
-  // A struct that holds the condition var and related stuff to allow notifies to be sent to the tread owning
+  // A struct that holds the condition var and related stuff to allow notifies to be sent to the thread owning
   // the struct.
   struct ZoneWaiter
   {

diff --git a/pdns/recursordist/settings/docs-new-preamble-in.rst b/pdns/recursordist/settings/docs-new-preamble-in.rst
index 186150186381f8af8c016816f9690827046d3d19..5d677c4eb53224ca8fa5ce935a1efdbe76fbff84 100644 (file)
--- a/pdns/recursordist/settings/docs-new-preamble-in.rst
+++ b/pdns/recursordist/settings/docs-new-preamble-in.rst
@@ -492,7 +492,7 @@ As of version 5.2.0, a forwarding catalog zone entry is defined as:
        localAddress: IP address, default not set
        axfrTimeout: number, default 20
      groups:
-     - name:
+     - name: optional group name
        forwarders: [] Sequence of SocketAddress
        recurse: bool, default false
        notify: bool, default false