]> git.ipfire.org Git - thirdparty/knot-resolver.git/commitdiff
version module: more understandable logging
authorVladimír Čunát <vladimir.cunat@nic.cz>
Mon, 5 Feb 2018 10:01:03 +0000 (11:01 +0100)
committerVladimír Čunát <vladimir.cunat@nic.cz>
Mon, 5 Feb 2018 13:04:23 +0000 (14:04 +0100)
Just loading the module without option was printing that it expected
number of milliseconds, which could've been confusing.

modules/version/version.lua.in

index 05cd92d2fb9a65fc315a7d28bd8ecf5c98ded20d..3585c359e4ba46649cad2b457cf72c3948f12349 100644 (file)
@@ -42,7 +42,7 @@ local function request (answer)
     if pkt:rcode() == kres.rcode.NOERROR then
         parse(pkt:rrsets(kres.section.ANSWER)[1])
     else
-        print ('Request for version ended with rcode: ', pkt:rcode())
+        log('[version] Request for version ended with rcode: ', pkt:rcode())
         return
     end
 end
@@ -52,12 +52,8 @@ local function callhome()
 end
 
 function M.config(period)
-    if period == nil then
-        print("Expected number of miliseconds. Using default version.config(1*day)")
-        return
-    end
-    if type(period) ~= "number" then
-        print("Expected number of miliseconds. Using default version.config(1*day)")
+    if not period or type(period) ~= "number" then
+        log("[version] Using default version.config(1*day)")
         return
     end
     M.period = period