]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
eth: fbnic: Use GFP_KERNEL to allocting mbx pages
authorMohsin Bashir <mohsin.bashr@gmail.com>
Thu, 15 Jan 2026 00:33:49 +0000 (16:33 -0800)
committerJakub Kicinski <kuba@kernel.org>
Wed, 21 Jan 2026 02:18:41 +0000 (18:18 -0800)
Replace GFP_ATOMIC with GFP_KERNEL for mailbox RX page allocation. Since
interrupt handler is threaded GFP_KERNEL is a safe option to reduce
allocation failures.

Also remove __GFP_NOWARN so the kernel reports a warning on allocation
failure to aid debugging.

Signed-off-by: Mohsin Bashir <mohsin.bashr@gmail.com>
Link: https://patch.msgid.link/20260115003353.4150771-2-mohsin.bashr@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/meta/fbnic/fbnic_fw.c

index d8d9b6cfde82c38010d9025f9c4c4b5323c2e813..3dfd3f2442ff097fad759102178f9a5a34d46eec 100644 (file)
@@ -205,8 +205,7 @@ static int fbnic_mbx_alloc_rx_msgs(struct fbnic_dev *fbd)
        while (!err && count--) {
                struct fbnic_tlv_msg *msg;
 
-               msg = (struct fbnic_tlv_msg *)__get_free_page(GFP_ATOMIC |
-                                                             __GFP_NOWARN);
+               msg = (struct fbnic_tlv_msg *)__get_free_page(GFP_KERNEL);
                if (!msg) {
                        err = -ENOMEM;
                        break;