re PR preprocessor/8524 (_Pragma within macros is improperly expanded)

	PR preprocessor/8524
	* cpplib.c (run_directive): Remove previous kludge to _Pragma.
	Add a new one in its place, which hopefully works.
	(skip_rest_of_line): Change test for bottom-of-context-stack.
testsuite:
	* gcc.dg/cpp/_Pragma5.c: New test.

From-SVN: r59534

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 04122275c2bfe6d2fc4b7619084f01c2ac1945de..0c16f377eb796a6beddcf1c77d4358ae470251a4 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,10 @@
+2002-11-26  Neil Booth  <neil@daikokuya.co.uk>
+
+       PR preprocessor/8524
+       * cpplib.c (run_directive): Remove previous kludge to _Pragma.
+       Add a new one in its place, which hopefully works.
+       (skip_rest_of_line): Change test for bottom-of-context-stack.
+
 2002-11-26  David Edelsohn  <edelsohn@gnu.org>
 
         * config/rs6000/rs6000.c (rs6000_flag_pic): New variable.

diff --git a/gcc/cpplib.c b/gcc/cpplib.c
index cff9eeb04286bf1aa98a773ac4a78b05a6062190..0f0063bc9dde91ecd2270001832eb02220c7f125 100644 (file)
--- a/gcc/cpplib.c
+++ b/gcc/cpplib.c
@@ -210,7 +210,7 @@ skip_rest_of_line (pfile)
      cpp_reader *pfile;
 {
   /* Discard all stacked contexts.  */
-  while (pfile->context != &pfile->base_context)
+  while (pfile->context->prev)
     _cpp_pop_context (pfile);
 
   /* Sweep up all tokens remaining on the line.  */
@@ -1224,9 +1224,6 @@ destringize_and_run (pfile, in)
 {
   const unsigned char *src, *limit;
   char *dest, *result;
-  cpp_context saved_context;
-  cpp_context *saved_cur_context;
-  unsigned int saved_line;
 
   dest = result = alloca (in->len + 1);
   for (src = in->text, limit = src + in->len; src < limit;)
@@ -1238,24 +1235,28 @@ destringize_and_run (pfile, in)
     }
   *dest = '\0';
 
-  /* FIXME.  All this saving is a horrible kludge to handle the case
-     when we're in a macro expansion.
-                                     
-     A better strategy it to not convert _Pragma to #pragma if doing
-     preprocessed output, but to just pass it through as-is, unless it
-     is a CPP pragma in which case is should be processed normally.
-     When compiling the preprocessed output the _Pragma should be  
-     handled.  This will be become necessary when we move to     
-     line-at-a-time lexing since we will be macro-expanding the line                   
-     before outputting / compiling it.  */
-  saved_line = pfile->line;
-  saved_context = pfile->base_context;
-  saved_cur_context = pfile->context;
-  pfile->context = &pfile->base_context;
-  run_directive (pfile, T_PRAGMA, result, dest - result);
-  pfile->context = saved_cur_context;
-  pfile->base_context = saved_context;
-  pfile->line = saved_line;
+  /* Ugh; an awful kludge.  We are really not set up to be lexing
+     tokens when in the middle of a macro expansion.  Use a new
+     context to force cpp_get_token to lex, and so skip_rest_of_line
+     doesn't go beyond the end of the text.  Also, remember the
+     current lexing position so we can return to it later.
+
+     Something like line-at-a-time lexing should remove the need for
+     this.  */
+  {
+    cpp_context *saved_context = pfile->context;
+    cpp_token *saved_cur_token = pfile->cur_token;
+    tokenrun *saved_cur_run = pfile->cur_run;
+
+    pfile->context = xnew (cpp_context);
+    pfile->context->macro = 0;
+    pfile->context->prev = 0;
+    run_directive (pfile, T_PRAGMA, result, dest - result);
+    free (pfile->context);
+    pfile->context = saved_context;
+    pfile->cur_token = saved_cur_token;
+    pfile->cur_run = saved_cur_run;
+  }
 
   /* See above comment.  For the moment, we'd like
 

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 3384474713990718cef7400cf343aaeb945a9268..7b41c9ee71ccca0921b1a532a43a6faa1d60e079 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2002-11-26  Neil Booth  <neil@daikokuya.co.uk>
+
+       * gcc.dg/cpp/_Pragma5.c: New test.
+
 2002-11-24  Eric Botcazou  <ebotcazou@libertysurf.fr>
 
        * gcc.c-torture/compile/20021124-1.c: New test.