]> git.ipfire.org Git - thirdparty/libnl.git/commitdiff
route/link: pass proper type to sizeof() for calloc() in vlan_parse()
authorThomas Haller <thaller@redhat.com>
Tue, 10 Jun 2014 16:20:25 +0000 (18:20 +0200)
committerThomas Haller <thaller@redhat.com>
Tue, 10 Jun 2014 19:45:33 +0000 (21:45 +0200)
This fixes the following coverity warning:
  lib/route/link/vlan.c:148:23:warning – Result of 'calloc' is converted to a pointer of type 'struct vlan_map', which is incompatible with sizeof operand type 'struct ifla_vlan_qos_mapping'

This was not a real problem, because the types are effectively
the same.

Acked-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: Thomas Haller <thaller@redhat.com>
lib/route/link/vlan.c

index 1a0d91612338b01c21ba6153493815fb73f6925b..b9f0c6609de1a35f924b327199cc32f877b83664 100644 (file)
@@ -145,7 +145,7 @@ static int vlan_parse(struct rtnl_link *link, struct nlattr *data,
 
                /* align to have a little reserve */
                vi->vi_egress_size = (i + 32) & ~31;
-               vi->vi_egress_qos = calloc(vi->vi_egress_size, sizeof(*map));
+               vi->vi_egress_qos = calloc(vi->vi_egress_size, sizeof(*vi->vi_egress_qos));
                if (vi->vi_egress_qos == NULL)
                        return -NLE_NOMEM;