]> git.ipfire.org Git - thirdparty/bootstrap.git/commitdiff
Offcanvas not showing with .showing (#36353)
authorJustin Kruit <justinkruitnl@gmail.com>
Sat, 14 May 2022 18:36:01 +0000 (20:36 +0200)
committerGitHub <noreply@github.com>
Sat, 14 May 2022 18:36:01 +0000 (21:36 +0300)
The transform of .showing was being overridden by .offcanvas.offcanvas-start, while .show wasn't. This resulted in an illusion of the offcanvas waiting for the backdrop, reported in #36347. Moving the show classes below the position classes fixes this problem.

scss/_offcanvas.scss

index e923db2f2481b408c3214df300f695d3b0c6652a..5709479dc480589577f86a8e5c5b29d6dd984b1c 100644 (file)
       @include box-shadow(var(--#{$prefix}offcanvas-box-shadow));
       @include transition(transform $offcanvas-transition-duration ease-in-out);
 
-      &.showing,
-      &.show:not(.hiding) {
-        transform: none;
-      }
-
-      &.showing,
-      &.hiding,
-      &.show {
-        visibility: visible;
-      }
-
       &.offcanvas-start {
         top: 0;
         left: 0;
         border-top: var(--#{$prefix}offcanvas-border-width) solid var(--#{$prefix}offcanvas-border-color);
         transform: translateY(100%);
       }
+
+      &.showing,
+      &.show:not(.hiding) {
+        transform: none;
+      }
+
+      &.showing,
+      &.hiding,
+      &.show {
+        visibility: visible;
+      }
     }
 
     @if not ($infix == "") {