]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
vz: remove redundant NULL pointer check
authorJán Tomko <jtomko@redhat.com>
Sun, 2 Aug 2020 20:52:51 +0000 (22:52 +0200)
committerJán Tomko <jtomko@redhat.com>
Mon, 3 Aug 2020 13:19:28 +0000 (15:19 +0200)
The 'dom' pointer is already dereferenced earlier.

src/vz/vz_sdk.c:249:24: warning: Either the condition 'if(dom)'
is redundant or there is possible null pointer dereference:
dom. [nullPointerRedundantCheck]

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
src/vz/vz_sdk.c

index b5e69b385f483ad378dade776080b7f36b8d14e4..bb1ef0ea47d36555829c83510eb442db30f386b6 100644 (file)
@@ -256,11 +256,11 @@ waitDomainJobHelper(PRL_HANDLE job, virDomainObjPtr dom, unsigned int timeout,
     }
 
     pdom->job.sdkJob = job;
-    if (dom)
-        virObjectUnlock(dom);
+
+    virObjectUnlock(dom);
     ret = waitJobHelper(job, timeout, filename, funcname, linenr);
-    if (dom)
-        virObjectLock(dom);
+    virObjectLock(dom);
+
     pdom->job.sdkJob = NULL;
 
     return ret;