auth: db-ldap - Fix deleting wrong LDAP request when ldap_search() or ldap_bind(...

This mainly means that if an invalid LDAP filter was used, wrong request
could have become deleted. Fixes:

Error: ldap(...): Reply with unknown msgid 2
Panic: file db-ldap.c: line 1343 (db_ldap_conn_close): assertion failed: (request->msgid != -1)

diff --git a/src/auth/db-ldap.c b/src/auth/db-ldap.c
index b3f6d27cffc2b1fc05f756d08d4ef92edc64e13d..2f9f93b23503a05dcef2c6c3d4ea71df46a6d9b2 100644 (file)
--- a/src/auth/db-ldap.c
+++ b/src/auth/db-ldap.c
@@ -433,7 +433,7 @@ static bool db_ldap_request_queue_next(struct ldap_connection *conn)
                return FALSE;
        } else {
                /* broken request, remove from queue */
-               aqueue_delete_tail(conn->request_queue);
+               aqueue_delete(conn->request_queue, conn->pending_count);
                request->callback(conn, request, NULL);
                return TRUE;
        }