]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ASoC: sdca: Fix missing regmap dependencies in Kconfig
authorBoris Faure <boris@fau.re>
Thu, 29 Jan 2026 14:14:54 +0000 (14:14 +0000)
committerMark Brown <broonie@kernel.org>
Thu, 29 Jan 2026 14:16:59 +0000 (14:16 +0000)
The SDCA modules failed to build with modpost errors:

  ERROR: modpost: "__devm_regmap_init_sdw" [sound/soc/sdca/snd-soc-sdca-class.ko] undefined!
  ERROR: modpost: "__devm_regmap_init_sdw_mbq" [sound/soc/sdca/snd-soc-sdca-class-function.ko] undefined!

The issue occurs because:
- sdca_class.c calls devm_regmap_init_sdw() which requires REGMAP_SOUNDWIRE
- sdca_class_function.c calls devm_regmap_init_sdw_mbq_cfg() which requires REGMAP_SOUNDWIRE_MBQ

However, the Kconfig didn't select these dependencies, causing the symbols
to be unavailable when the SDCA modules are built.

Fix this by adding:
- select REGMAP_SOUNDWIRE to SND_SOC_SDCA_CLASS
- select REGMAP_SOUNDWIRE_MBQ to SND_SOC_SDCA_CLASS_FUNCTION

This ensures the required regmap drivers are enabled when building SDCA support.

Configuration after fix:
  CONFIG_SND_SOC_SDCA_CLASS=m
  CONFIG_SND_SOC_SDCA_CLASS_FUNCTION=m
  CONFIG_REGMAP_SOUNDWIRE=m
  CONFIG_REGMAP_SOUNDWIRE_MBQ=m

Signed-off-by: Boris Faure <boris@fau.re>
Link: https://patch.msgid.link/20260129141419.13843-1-boris@fau.re
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sdca/Kconfig

index fabb69a3450d3b11327bcc7658bb54b057dcb47d..87ab2895096c1dac20a85fadbcf6c5d8080b8f22 100644 (file)
@@ -46,12 +46,14 @@ config SND_SOC_SDCA_CLASS
        select SND_SOC_SDCA_FDL
        select SND_SOC_SDCA_HID
        select SND_SOC_SDCA_IRQ
+       select REGMAP_SOUNDWIRE
        help
          This option enables support for the SDCA Class driver which should
          support any class compliant SDCA part.
 
 config SND_SOC_SDCA_CLASS_FUNCTION
        tristate
+       select REGMAP_SOUNDWIRE_MBQ
        help
          This option enables support for the SDCA Class Function drivers,
          these implement the individual functions of the SDCA Class driver.