]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
dma: dma-axi-dmac: fix HW scatter-gather not looking at the queue
authorNuno Sá <nuno.sa@analog.com>
Tue, 4 Nov 2025 16:22:26 +0000 (16:22 +0000)
committerVinod Koul <vkoul@kernel.org>
Tue, 23 Dec 2025 11:13:15 +0000 (16:43 +0530)
For HW scatter gather transfers we still need to look for the queue. The
HW is capable of queueing 3 concurrent transfers and if we try more than
that we'll get the submit queue full and should return. Otherwise, if we
go ahead and program the new transfer, we end up discarding it.

Fixes: e97dc7435972 ("dmaengine: axi-dmac: Add support for scatter-gather transfers")
Signed-off-by: Nuno Sá <nuno.sa@analog.com>
base-commit: 398035178503bf662281bbffb4bebce1460a4bc5
change-id: 20251104-axi-dmac-fixes-and-improvs-e3ad512a329c
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
Link: https://patch.msgid.link/20251104-axi-dmac-fixes-and-improvs-v1-2-3e6fd9328f72@analog.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/dma-axi-dmac.c

index e22639822045f237ebcd1fa012a75bbe7dc536c5..0f25f6d8ae71fa73fb24c58b3e2ecfea452cd158 100644 (file)
@@ -233,11 +233,9 @@ static void axi_dmac_start_transfer(struct axi_dmac_chan *chan)
        unsigned int flags = 0;
        unsigned int val;
 
-       if (!chan->hw_sg) {
-               val = axi_dmac_read(dmac, AXI_DMAC_REG_START_TRANSFER);
-               if (val) /* Queue is full, wait for the next SOT IRQ */
-                       return;
-       }
+       val = axi_dmac_read(dmac, AXI_DMAC_REG_START_TRANSFER);
+       if (val) /* Queue is full, wait for the next SOT IRQ */
+               return;
 
        desc = chan->next_desc;