irqchip/renesas-rzv2h: Use local device pointer in ICU probe

Use a local struct device pointer in rzv2h_icu_probe_common() to avoid
repeated dereferencing of pdev->dev.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Link: https://patch.msgid.link/20260304113317.129339-3-prabhakar.mahadev-lad.rj@bp.renesas.com

diff --git a/drivers/irqchip/irq-renesas-rzv2h.c b/drivers/irqchip/irq-renesas-rzv2h.c
index 20c0cd11ef25b18ecd9396df1ae16717dff9c448..766b981cf3d8d77daef3376795279fd2c7611149 100644 (file)
--- a/drivers/irqchip/irq-renesas-rzv2h.c
+++ b/drivers/irqchip/irq-renesas-rzv2h.c
@@ -555,57 +555,58 @@ static int rzv2h_icu_probe_common(struct platform_device *pdev, struct device_no
 {
        struct irq_domain *irq_domain, *parent_domain;
        struct device_node *node = pdev->dev.of_node;
+       struct device *dev = &pdev->dev;
        struct reset_control *resetn;
        int ret;
 
        parent_domain = irq_find_host(parent);
        if (!parent_domain) {
-               dev_err(&pdev->dev, "cannot find parent domain\n");
+               dev_err(dev, "cannot find parent domain\n");
                return -ENODEV;
        }
 
-       rzv2h_icu_data = devm_kzalloc(&pdev->dev, sizeof(*rzv2h_icu_data), GFP_KERNEL);
+       rzv2h_icu_data = devm_kzalloc(dev, sizeof(*rzv2h_icu_data), GFP_KERNEL);
        if (!rzv2h_icu_data)
                return -ENOMEM;
 
        platform_set_drvdata(pdev, rzv2h_icu_data);
 
-       rzv2h_icu_data->base = devm_of_iomap(&pdev->dev, node, 0, NULL);
+       rzv2h_icu_data->base = devm_of_iomap(dev, node, 0, NULL);
        if (IS_ERR(rzv2h_icu_data->base))
                return PTR_ERR(rzv2h_icu_data->base);
 
        ret = rzv2h_icu_parse_interrupts(rzv2h_icu_data, node);
        if (ret) {
-               dev_err(&pdev->dev, "cannot parse interrupts: %d\n", ret);
+               dev_err(dev, "cannot parse interrupts: %d\n", ret);
                return ret;
        }
 
-       resetn = devm_reset_control_get_exclusive_deasserted(&pdev->dev, NULL);
+       resetn = devm_reset_control_get_exclusive_deasserted(dev, NULL);
        if (IS_ERR(resetn)) {
                ret = PTR_ERR(resetn);
-               dev_err(&pdev->dev, "failed to acquire deasserted reset: %d\n", ret);
+               dev_err(dev, "failed to acquire deasserted reset: %d\n", ret);
                return ret;
        }
 
-       ret = devm_pm_runtime_enable(&pdev->dev);
+       ret = devm_pm_runtime_enable(dev);
        if (ret < 0) {
-               dev_err(&pdev->dev, "devm_pm_runtime_enable failed, %d\n", ret);
+               dev_err(dev, "devm_pm_runtime_enable failed, %d\n", ret);
                return ret;
        }
 
-       ret = pm_runtime_resume_and_get(&pdev->dev);
+       ret = pm_runtime_resume_and_get(dev);
        if (ret < 0) {
-               dev_err(&pdev->dev, "pm_runtime_resume_and_get failed: %d\n", ret);
+               dev_err(dev, "pm_runtime_resume_and_get failed: %d\n", ret);
                return ret;
        }
 
        raw_spin_lock_init(&rzv2h_icu_data->lock);
 
        irq_domain = irq_domain_create_hierarchy(parent_domain, 0, ICU_NUM_IRQ,
-                                                dev_fwnode(&pdev->dev), &rzv2h_icu_domain_ops,
+                                                dev_fwnode(dev), &rzv2h_icu_domain_ops,
                                                 rzv2h_icu_data);
        if (!irq_domain) {
-               dev_err(&pdev->dev, "failed to add irq domain\n");
+               dev_err(dev, "failed to add irq domain\n");
                ret = -ENOMEM;
                goto pm_put;
        }
@@ -616,12 +617,12 @@ static int rzv2h_icu_probe_common(struct platform_device *pdev, struct device_no
 
        /*
         * coccicheck complains about a missing put_device call before returning, but it's a false
-        * positive. We still need &pdev->dev after successfully returning from this function.
+        * positive. We still need dev after successfully returning from this function.
         */
        return 0;
 
 pm_put:
-       pm_runtime_put(&pdev->dev);
+       pm_runtime_put(dev);
 
        return ret;
 }