]> git.ipfire.org Git - thirdparty/freeradius-server.git/commitdiff
better notes on stream transport issues
authorAlan T. DeKok <aland@freeradius.org>
Wed, 24 May 2017 15:57:29 +0000 (11:57 -0400)
committerAlan T. DeKok <aland@freeradius.org>
Wed, 24 May 2017 15:57:29 +0000 (11:57 -0400)
src/lib/io/network.c

index 73ef04a385249771e934f67895b312ecaa782086..a0be022b9e7803d6bbf5930dffcd896e9abc645b 100644 (file)
@@ -362,16 +362,9 @@ static void fr_network_read(UNUSED fr_event_list_t *el, int sockfd, void *ctx)
                 *      need to be able to give the same buffer back
                 *      to the stream socket for subsequent reads.
                 *
-                *      The only worry with this approach is that slow
-                *      stream sockets MAY do "head of line" blocking
-                *      on the ring buffers.
-                *
-                *      i.e. if the transport read returns 0, we MAY
-                *      want to copy the data somewhere else.  OR, we
-                *      may want to relax our promises to the
-                *      transport, and demand that the transport not
-                *      write to the message buffer until it has an
-                *      entire packet.
+                *      Since we have a message set for each
+                *      fr_transport_socket_t, no "head of line"
+                *      blocking issues can happen for stream sockets.
                 */
                s->cd = cd;
                return;