]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
apparmor: Fix use of uninitialized random_data
authorJiri Denemark <jdenemar@redhat.com>
Fri, 27 Jan 2012 10:14:21 +0000 (11:14 +0100)
committerJiri Denemark <jdenemar@redhat.com>
Fri, 27 Jan 2012 10:14:21 +0000 (11:14 +0100)
Without this, virt-aa-helper would segfault in -c or -r commands.

src/security/virt-aa-helper.c

index 4561bb9db48d0cc62e75cc029766babd2f365372..b484a2029e8c0d6513bd65f8a7e067d36fa53026 100644 (file)
@@ -42,6 +42,7 @@
 #include "pci.h"
 #include "virfile.h"
 #include "configmake.h"
+#include "virrandom.h"
 
 #define VIR_FROM_THIS VIR_FROM_SECURITY
 
@@ -1182,6 +1183,9 @@ main(int argc, char **argv)
 
     memset(ctl, 0, sizeof(vahControl));
 
+    if (virRandomInitialize(time(NULL) ^ getpid()) < 0)
+        vah_error(ctl, 1, _("could not initialize random generator"));
+
     if (vahParseArgv(ctl, argc, argv) != 0)
         vah_error(ctl, 1, _("could not parse arguments"));