patch 9.1.0511: CursorMovedC triggered wrongly with setcmdpos()

Problem:  CursorMovedC triggered wrongly with setcmdpos()
          (after v9.1.0507)
Solution: Remove the premature triggering.  Also don't trigger when
          cursor didn't move. (zeertzjq)

closes: #15064

Signed-off-by: zeertzjq <zeertzjq@outlook.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>

diff --git a/runtime/doc/autocmd.txt b/runtime/doc/autocmd.txt
index 27ab2c73c5ae40f5cb34247867c7fba9ed888a2e..e19d6015e8b913d8b9ed3cd477d5d5319f387c30 100644 (file)
--- a/runtime/doc/autocmd.txt
+++ b/runtime/doc/autocmd.txt
@@ -1,4 +1,4 @@
-*autocmd.txt*   For Vim version 9.1.  Last change: 2024 Jun 20
+*autocmd.txt*   For Vim version 9.1.  Last change: 2024 Jun 21
 
 
                  VIM REFERENCE MANUAL    by Bram Moolenaar
@@ -751,7 +751,8 @@ CursorMoved                 After the cursor was moved in Normal or Visual
                                that is slow.
                                                        *CursorMovedC*
 CursorMovedC                   After the cursor was moved in the command
-                               line. Be careful not to mess up the
+                               line while the text in the command line hasn't
+                               changed.  Be careful not to mess up the
                                command line, it may cause Vim to lock up.
                                <afile> is set to a single character,
                                indicating the type of command-line.

diff --git a/src/ex_getln.c b/src/ex_getln.c
index 481b450dc1a90cb6ff45cc5b9fcb1c41864b29c9..f05259bb9d0bcc962351f220e8cf6fd2b66bd0eb 100644 (file)
--- a/src/ex_getln.c
+++ b/src/ex_getln.c
@@ -1586,7 +1586,7 @@ getcmdline_int(
     int                res;
     int                save_msg_scroll = msg_scroll;
     int                save_State = State;     // remember State when called
-    int                save_cmdspos = ccline.cmdspos;
+    int                prev_cmdpos = -1;
     int                some_key_typed = FALSE; // one of the keys was typed
     // mouse drag and release events are ignored, unless they are
     // preceded with a mouse down event
@@ -2474,16 +2474,19 @@ getcmdline_int(
  * (Sorry for the goto's, I know it is ugly).
  */
 cmdline_not_changed:
-        // Trigger CursorMovedC autocommands.
-        if (ccline.cmdspos != save_cmdspos)
+       // Trigger CursorMovedC autocommands.
+       if (ccline.cmdpos != prev_cmdpos)
+       {
            trigger_cmd_autocmd(cmdline_type, EVENT_CURSORMOVEDC);
-
+           prev_cmdpos = ccline.cmdpos;
+       }
 #ifdef FEAT_SEARCH_EXTRA
        if (!is_state.incsearch_postponed)
            continue;
 #endif
 
 cmdline_changed:
+       prev_cmdpos = ccline.cmdpos;
 #ifdef FEAT_SEARCH_EXTRA
        // If the window changed incremental search state is not valid.
        if (is_state.winid != curwin->w_id)
@@ -4321,9 +4324,6 @@ set_cmdline_pos(
     else
        new_cmdpos = pos;
 
-    // Trigger CursorMovedC autocommands.
-    trigger_cmd_autocmd(get_cmdline_type(), EVENT_CURSORMOVEDC);
-
     return 0;
 }
 

diff --git a/src/testdir/test_autocmd.vim b/src/testdir/test_autocmd.vim
index faa0f9771c974347a9ba66114130d99099684c11..371abcbd752e33a711156a9f066daf8a7d49efce 100644 (file)
--- a/src/testdir/test_autocmd.vim
+++ b/src/testdir/test_autocmd.vim
@@ -2097,20 +2097,28 @@ func Test_Cmdline()
   au! CmdlineLeave
   let &shellslash = save_shellslash
 
-  au! CursorMovedC : let g:pos = getcmdpos()
-  let g:pos = 0
-  call feedkeys(":hello\<Left>\<ESC>", 'xt')
-  call assert_equal(5, g:pos)
-  call feedkeys(":12345678\<C-R>=setcmdpos(3)\<CR>\<ESC>", 'xt')
-  call assert_equal(3, g:pos)
+  au! CursorMovedC : let g:pos += [getcmdpos()]
+  let g:pos = []
+  call feedkeys(":hello\<Left>\<C-R>=''\<CR>\<Left>\<Right>\<Esc>", 'xt')
+  call assert_equal([5, 4, 5], g:pos)
+  let g:pos = []
+  call feedkeys(":12345678\<C-R>=setcmdpos(3)??''\<CR>\<Esc>", 'xt')
+  call assert_equal([3], g:pos)
+  let g:pos = []
+  call feedkeys(":12345678\<C-R>=setcmdpos(3)??''\<CR>\<Left>\<Esc>", 'xt')
+  call assert_equal([3, 2], g:pos)
   au! CursorMovedC
 
-  " CursorMovedC changes the cursor position.
-  au! CursorMovedC : let g:pos = getcmdpos() | call setcmdpos(getcmdpos()-1)
-  let g:pos = 0
-  call feedkeys(":hello\<Left>\<ESC>", 'xt')
-  call assert_equal(5, g:pos)
+  " setcmdpos() is no-op inside an autocommand
+  au! CursorMovedC : let g:pos += [getcmdpos()] | call setcmdpos(1)
+  let g:pos = []
+  call feedkeys(":hello\<Left>\<Left>\<Esc>", 'xt')
+  call assert_equal([5, 4], g:pos)
   au! CursorMovedC
+
+  unlet g:entered
+  unlet g:left
+  unlet g:pos
 endfunc
 
 " Test for BufWritePre autocommand that deletes or unloads the buffer.

diff --git a/src/version.c b/src/version.c
index f856876e3f82cade262b063b23f8e965d6b84174..e0b0d5ccf30859ca6614aaec7dfd6d252197404e 100644 (file)
--- a/src/version.c
+++ b/src/version.c
@@ -704,6 +704,8 @@ static char *(features[]) =
 
 static int included_patches[] =
 {   /* Add new patch number below this line */
+/**/
+    511,
 /**/
     510,
 /**/