]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
xfs: fixed signedness of error code in xfs_inode_buf_verify
authorJeff Mahoney <jeffm@suse.com>
Thu, 6 Oct 2016 06:18:16 +0000 (08:18 +0200)
committerJiri Slaby <jslaby@suse.cz>
Thu, 6 Oct 2016 06:22:04 +0000 (08:22 +0200)
Prior to v3.17, XFS used positive error codes internally.  Commit
af8d971602b9583e5e8400e637e2a48c7480bc64 (xfs: inode recovery
readahead can race with inode buffer creation), upstream commit
b79f4a1c68bb99152d0785ee4ea3ab4396cdacc6 backported from later
releases need the error code signs reversed.  Negative error codes
will cause assertion failures (BUG_ON on kernels with assertions
enabled.

Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Cc: Dave Chinner <dchinner@redhat.com>
Cc: Brian Foster <bfoster@redhat.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
fs/xfs/xfs_inode_buf.c

index 4b1447b3a9e440981895b0bbfcb6544037cae4a3..03d237a0f58b1d32a9bfc6f44724a37c04986500 100644 (file)
@@ -99,7 +99,7 @@ xfs_inode_buf_verify(
                                                XFS_RANDOM_ITOBP_INOTOBP))) {
                        if (readahead) {
                                bp->b_flags &= ~XBF_DONE;
-                               xfs_buf_ioerror(bp, -EIO);
+                               xfs_buf_ioerror(bp, EIO);
                                return;
                        }