if we print (null) in an RR, we should return an error status

(maybe even set buffer status to error?)

diff --git a/host2str.c b/host2str.c
index 2ec8ae19f34f153fb4d6248916f16a678c6e7032..858b1c11a9deee0ba37728ef77513ba51bca6712 100644 (file)
--- a/host2str.c
+++ b/host2str.c
@@ -1152,7 +1152,7 @@ ldns_rdf2buffer_str(ldns_buffer *buffer, const ldns_rdf *rdf)
        } else {
                /** This will write mangled RRs */
                ldns_buffer_printf(buffer, "(null) ");
-               res = ldns_buffer_status(buffer);
+               res = LDNS_STATUS_ERR;
        }
        return res;
 }

diff --git a/rr.c b/rr.c
index 8f4ce85c7eb571e9ab95bef6cf784241aac8eef4..e11594f5440701448a9db603fcc684ba7733fb7b 100644 (file)
--- a/rr.c
+++ b/rr.c
@@ -119,7 +119,7 @@ ldns_rr_new_frm_str_internal(ldns_rr **newrr, const char *str,
        char  *type = NULL;
        char  *rdata = NULL;
        char  *rd = NULL;
-       char  *b64 = NULL;
+       char  * b64 = NULL;
        size_t rd_strlen;
        const char *delimiters;
        ssize_t c;