]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
thermal: step_wise: Revert optimization
authorJean Delvare <jdelvare@suse.de>
Mon, 20 Apr 2015 09:21:13 +0000 (11:21 +0200)
committerJiri Slaby <jslaby@suse.cz>
Wed, 3 Jun 2015 09:33:13 +0000 (11:33 +0200)
Commit 178c2490b99f898efc06d1ad75cadc84f13021a6 ("thermal: step_wise:
cdev only needs update on a new target state") broke driver acerhdf.
That driver abused the step_wise thermal governor until the bang_bang
governor was available, and the optimization broke this usage model.

Kernels v3.12 to v3.18 are affected. In v3.19 the acerhdf driver was
switched to the bang_bang governor and that solved the problem.

For kernels v3.12 to v3.17, the bang_bang governor isn't available
yet so the easiest fix is to revert the optimization.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Reported-by: Dieter Jurzitza (https://bugzilla.opensuse.org/show_bug.cgi?id=925961)
Tested-by: Peter Feuerer <peter@piie.net>
Tested-by: Dieter Jurzitza
drivers/thermal/step_wise.c

index d89e781b0a18d9a71fce0ff18c77683c7699dc10..769bfa3a43604c3c8229f1c9ab03d5173e0d17c9 100644 (file)
@@ -140,9 +140,6 @@ static void thermal_zone_trip_update(struct thermal_zone_device *tz, int trip)
                old_target = instance->target;
                instance->target = get_target_state(instance, trend, throttle);
 
-               if (old_target == instance->target)
-                       continue;
-
                /* Activate a passive thermal instance */
                if (old_target == THERMAL_NO_TARGET &&
                        instance->target != THERMAL_NO_TARGET)