]> git.ipfire.org Git - thirdparty/openembedded/openembedded-core.git/commitdiff
kernel-fitimage: Adjust order of dtb/dtbo files
authorSandeep Gundlupet Raju <sandeep.gundlupet-raju@amd.com>
Wed, 4 Jan 2023 22:09:01 +0000 (15:09 -0700)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Thu, 12 Jan 2023 23:07:39 +0000 (23:07 +0000)
The dtb files must be before the dtbo files, otherwise the overlays may
not be applied correctly.

From Bruce Ashfield:

  We can split between dtbs and dtbos, they just need to be sorted
  for reproducibility reasons.

  Of course, this was only working by luck previously (before the
  sort), since it has always been gathering dtbs and dtbo's with
  find, depending on filesystem ordering for the order in the
  fitimage).

Signed-off-by: Sandeep Gundlupet Raju <sandeep.gundlupet-raju@amd.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/classes-recipe/kernel-fitimage.bbclass

index 7980910aa8c4d103a0a20a1a66931b96c283bc2d..92e236a0a464f9ae028001a765084d5f8f7586e4 100644 (file)
@@ -590,8 +590,9 @@ fitimage_assemble() {
 
        if [ -n "${EXTERNAL_KERNEL_DEVICETREE}" ]; then
                dtbcount=1
-               for DTB in $(find "${EXTERNAL_KERNEL_DEVICETREE}" \( -name '*.dtb' -o -name '*.dtbo' \) -printf '%P\n' | sort); do
-                       # Skip DTB if we've picked it up previously
+               for DTB in $(find "${EXTERNAL_KERNEL_DEVICETREE}" -name '*.dtb' -printf '%P\n' | sort) \
+               $(find "${EXTERNAL_KERNEL_DEVICETREE}" -name '*.dtbo' -printf '%P\n' | sort); do
+                       # Skip DTB/DTBO if we've picked it up previously
                        echo "$DTBS" | tr ' ' '\n' | grep -xq "$DTB" && continue
 
                        DTBS="$DTBS $DTB"