Fix for bug 52885: automatic radio selection for reassign shouldn't

trigger if new text is same as original owner or empty.

Patch by Christopher Aillon (caillon@returnzero.com). R=Bradley Baetz
(bbaetz@cs.mcgill.ca). No 2nd review needed.

diff --git a/bug_form.pl b/bug_form.pl
index 21e9e32cf5e71f47fb99818a62238d537276ca17..0ce4f29bd48f53cd02dda766259588a108cd21e0 100644 (file)
--- a/bug_form.pl
+++ b/bug_form.pl
@@ -498,7 +498,7 @@ if ($canedit || $::userid == $assignedtoid ||
         Resolve bug, mark it as duplicate of bug # 
         <INPUT NAME=dup_id SIZE=6 ONCHANGE=\"document.changeform.knob\[$knum\].checked=true\"><br>\n";
         $knum++;
-        my $assign_element = "<INPUT NAME=\"assigned_to\" SIZE=32 ONCHANGE=\"document.changeform.knob\[$knum\].checked=true\" VALUE=\"$bug{'assigned_to_email'}\">";
+        my $assign_element = "<INPUT NAME=\"assigned_to\" SIZE=32 ONCHANGE=\"if ((this.value != ".SqlQuote($bug{'assigned_to_email'}) .") && (this.value != '')) { document.changeform.knob\[$knum\].checked=true; }\" VALUE=\"$bug{'assigned_to_email'}\">";
 
         print "<INPUT TYPE=radio NAME=knob VALUE=reassign> 
           <A HREF=\"bug_status.html#assigned_to\">Reassign</A> bug to