]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
gpio: lpc32xx: remove redundant CONFIG_OF and of_match_ptr()
authorZhu Wang <wangzhu9@huawei.com>
Wed, 2 Aug 2023 03:17:49 +0000 (11:17 +0800)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Thu, 3 Aug 2023 13:58:49 +0000 (15:58 +0200)
The driver depends on CONFIG_OF, so it is not necessary to use
CONFIG_OF and of_match_ptr() here, so we remove them all.

Even for drivers that do not depend on CONFIG_OF, it's almost always
better to leave out the of_match_ptr(), since the only thing it can
possibly do is to save a few bytes of .text if a driver can be used both
with and without it.

Signed-off-by: Zhu Wang <wangzhu9@huawei.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
drivers/gpio/gpio-lpc32xx.c

index d2b65cfb336ea92a14e7ef309acdd91bb933eb8b..5ef8af8249806aa6c1b226ed4ab9219cca91d936 100644 (file)
@@ -525,17 +525,15 @@ static int lpc32xx_gpio_probe(struct platform_device *pdev)
        return 0;
 }
 
-#ifdef CONFIG_OF
 static const struct of_device_id lpc32xx_gpio_of_match[] = {
        { .compatible = "nxp,lpc3220-gpio", },
        { },
 };
-#endif
 
 static struct platform_driver lpc32xx_gpio_driver = {
        .driver         = {
                .name   = "lpc32xx-gpio",
-               .of_match_table = of_match_ptr(lpc32xx_gpio_of_match),
+               .of_match_table = lpc32xx_gpio_of_match,
        },
        .probe          = lpc32xx_gpio_probe,
 };