]> git.ipfire.org Git - thirdparty/mdadm.git/commitdiff
mdadm: Query.c fix coverity issues
authorNigel Croxon <ncroxon@redhat.com>
Tue, 16 Jul 2024 11:19:34 +0000 (07:19 -0400)
committerMariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
Tue, 16 Jul 2024 14:19:16 +0000 (16:19 +0200)
Fixing the following coding errors the coverity tools found:

* Event leaked_storage: Variable "sra" going out of scope leaks the
storage it points to.

* Event uninit_use_in_call: Using uninitialized value "larray_size" when
calling "human_size_brief".

Signed-off-by: Nigel Croxon <ncroxon@redhat.com>
Query.c

diff --git a/Query.c b/Query.c
index adcd231e051b19fa5fb5b418d5af6f2980a53dc5..aedb4ce77d8399db8428f5e84dc4f73b9547cdc9 100644 (file)
--- a/Query.c
+++ b/Query.c
@@ -39,7 +39,7 @@ int Query(char *dev)
        struct mdinfo info;
        struct mdinfo *sra;
        struct supertype *st = NULL;
-       unsigned long long larray_size;
+       unsigned long long larray_size = 0;
        struct stat stb;
        char *mddev;
        mdu_disk_info_t disc;
@@ -136,5 +136,7 @@ int Query(char *dev)
                if (st->ss == &super0)
                        put_md_name(mddev);
        }
+       free(sra);
+
        return 0;
 }