* Disable the Voting extension by default.

* There was a syntax error in the code-error-errors.html.tmpl hook in the
  Voting extension.
* Creating the TestProduct during checksetup was throwing an warning
  about use of an uninitialized value, due to the Voting extension.

https://bugzilla.mozilla.org/show_bug.cgi?id=372979

diff --git a/extensions/Voting/Extension.pm b/extensions/Voting/Extension.pm
index 6857135eb6d2fd6cddc7319f0e82017ca832b4cb..47105bf987ba4a4096b789eadffea1de3a1d49b2 100644 (file)
--- a/extensions/Voting/Extension.pm
+++ b/extensions/Voting/Extension.pm
@@ -326,7 +326,7 @@ sub _check_votestoconfirm {
 sub _check_votes {
     my ($default, $invocant, $votes, $field) = @_;
 
-    detaint_natural($votes);
+    detaint_natural($votes) if defined $votes;
     # On product creation, if the number of votes is not a valid integer,
     # we silently fall back to the given default value.
     # If the product already exists and the change is illegal, we complain.

diff --git a/extensions/Voting/disabled b/extensions/Voting/disabled
new file mode 100644 (file)
index 0000000..e69de29

diff --git a/extensions/Voting/template/en/default/hook/global/code-error-errors.html.tmpl b/extensions/Voting/template/en/default/hook/global/code-error-errors.html.tmpl
index 719cbe4c11e57292deb8044d0939e892ea7d9f19..50e9159416f2085795d456281ef3c84eb28ee840 100644 (file)
--- a/extensions/Voting/template/en/default/hook/global/code-error-errors.html.tmpl
+++ b/extensions/Voting/template/en/default/hook/global/code-error-errors.html.tmpl
@@ -22,3 +22,4 @@
     [% title = "$terms.Bug Cannot Be Confirmed" %]
     There is no valid transition from
     [%+ display_value("bug_status", "UNCONFIRMED") FILTER html %] to an open state
+[% END %]