wrapper: null terminated string in cgroup_add_controller()

Fix non-terminated string warning, reported by Coverity tool:

CID 258271 (#1 of 1): String not null terminated (STRING_NULL).
string_null: Passing unterminated string cgc->name to strcmp, which
expects a null-terminated string.

This issue was reported following the path src/abstraction-common.c:
- cgroup_convert_cgroup()
  - cgroup_add_controller()

Also, use CONTROL_NAMELEN_MAX macro, in place of calculating the size of
controller->name twice.

Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

diff --git a/src/wrapper.c b/src/wrapper.c
index 41eef292589d8866b2f829b2022650cfd2cca67b..933075dfcfa4307a4b8f7a73adc711deb3e5ca86 100644 (file)
--- a/src/wrapper.c
+++ b/src/wrapper.c
@@ -78,7 +78,9 @@ struct cgroup_controller *cgroup_add_controller(struct cgroup *cgroup,
        if (!controller)
                return NULL;
 
-       strncpy(controller->name, name, sizeof(controller->name) - 1);
+       strncpy(controller->name, name, CONTROL_NAMELEN_MAX - 1);
+       controller->name[CONTROL_NAMELEN_MAX - 1] = '\0';
+
        controller->cgroup = cgroup;
        controller->index = 0;