]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
dmaengine: at_xdmac: Remove redundant pm_runtime_mark_last_busy() calls
authorSakari Ailus <sakari.ailus@linux.intel.com>
Mon, 27 Oct 2025 13:32:27 +0000 (15:32 +0200)
committerVinod Koul <vkoul@kernel.org>
Tue, 16 Dec 2025 16:52:43 +0000 (22:22 +0530)
pm_runtime_put_autosuspend(), pm_runtime_put_sync_autosuspend(),
pm_runtime_autosuspend() and pm_request_autosuspend() now include a call
to pm_runtime_mark_last_busy(). Remove the now-reduntant explicit call to
pm_runtime_mark_last_busy().

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Link: https://patch.msgid.link/20251027133232.392898-1-sakari.ailus@linux.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/at_xdmac.c

index 3fbc74710a1336dfb0420fffdc9a1952da1a8f95..ada96d490847ce022ccee5225e3c0592fa90482b 100644 (file)
@@ -379,7 +379,6 @@ static void at_xdmac_runtime_suspend_descriptors(struct at_xdmac_chan *atchan)
                if (!desc->active_xfer)
                        continue;
 
-               pm_runtime_mark_last_busy(atxdmac->dev);
                pm_runtime_put_autosuspend(atxdmac->dev);
        }
 }
@@ -413,7 +412,6 @@ static bool at_xdmac_chan_is_enabled(struct at_xdmac_chan *atchan)
 
        ret = !!(at_xdmac_chan_read(atchan, AT_XDMAC_GS) & atchan->mask);
 
-       pm_runtime_mark_last_busy(atxdmac->dev);
        pm_runtime_put_autosuspend(atxdmac->dev);
 
        return ret;
@@ -446,7 +444,6 @@ static void at_xdmac_off(struct at_xdmac *atxdmac, bool suspend_descriptors)
                }
        }
 
-       pm_runtime_mark_last_busy(atxdmac->dev);
        pm_runtime_put_autosuspend(atxdmac->dev);
 }
 
@@ -1676,7 +1673,6 @@ at_xdmac_tx_status(struct dma_chan *chan, dma_cookie_t cookie,
 
 spin_unlock:
        spin_unlock_irqrestore(&atchan->lock, flags);
-       pm_runtime_mark_last_busy(atxdmac->dev);
        pm_runtime_put_autosuspend(atxdmac->dev);
        return ret;
 }
@@ -1758,7 +1754,6 @@ static void at_xdmac_handle_error(struct at_xdmac_chan *atchan)
                __func__, &bad_desc->lld.mbr_sa, &bad_desc->lld.mbr_da,
                bad_desc->lld.mbr_ubc);
 
-       pm_runtime_mark_last_busy(atxdmac->dev);
        pm_runtime_put_autosuspend(atxdmac->dev);
 
        /* Then continue with usual descriptor management */
@@ -1822,7 +1817,6 @@ static void at_xdmac_tasklet(struct tasklet_struct *t)
         * Decrement runtime PM ref counter incremented in
         * at_xdmac_start_xfer().
         */
-       pm_runtime_mark_last_busy(atxdmac->dev);
        pm_runtime_put_autosuspend(atxdmac->dev);
 }
 
@@ -1954,7 +1948,6 @@ static int at_xdmac_device_pause(struct dma_chan *chan)
 
        spin_unlock_irqrestore(&atchan->lock, flags);
 
-       pm_runtime_mark_last_busy(atxdmac->dev);
        pm_runtime_put_autosuspend(atxdmac->dev);
 
        return 0;
@@ -1998,7 +1991,6 @@ static int at_xdmac_device_resume(struct dma_chan *chan)
 
 unlock:
        spin_unlock_irqrestore(&atchan->lock, flags);
-       pm_runtime_mark_last_busy(atxdmac->dev);
        pm_runtime_put_autosuspend(atxdmac->dev);
 
        return ret;
@@ -2041,7 +2033,6 @@ static int at_xdmac_device_terminate_all(struct dma_chan *chan)
        clear_bit(AT_XDMAC_CHAN_IS_CYCLIC, &atchan->status);
        spin_unlock_irqrestore(&atchan->lock, flags);
 
-       pm_runtime_mark_last_busy(atxdmac->dev);
        pm_runtime_put_autosuspend(atxdmac->dev);
 
        return 0;
@@ -2235,7 +2226,6 @@ static int __maybe_unused atmel_xdmac_resume(struct device *dev)
                }
        }
 
-       pm_runtime_mark_last_busy(atxdmac->dev);
        pm_runtime_put_autosuspend(atxdmac->dev);
 
        return 0;
@@ -2412,7 +2402,6 @@ static int at_xdmac_probe(struct platform_device *pdev)
 
        at_xdmac_axi_config(pdev);
 
-       pm_runtime_mark_last_busy(&pdev->dev);
        pm_runtime_put_autosuspend(&pdev->dev);
 
        return 0;