]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
media: qcom: camss: Restrict endpoint bus-type to D-PHY
authorLuca Weiss <luca.weiss@fairphone.com>
Mon, 9 Dec 2024 12:01:06 +0000 (13:01 +0100)
committerHans Verkuil <hverkuil@xs4all.nl>
Fri, 11 Apr 2025 11:29:06 +0000 (13:29 +0200)
Currently the Qualcomm CAMSS driver only supports D-PHY while the
hardware on most SoCs also supports C-PHY. Until this support is added,
check for D-PHY to make it somewhat explicit that C-PHY won't work.

Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
Tested-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Signed-off-by: Bryan O'Donoghue <bod@kernel.org>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
drivers/media/platform/qcom/camss/camss.c

index 6791dfea91b13d584694a26599e24ca088dfc1ab..8fcfe06449bf91a7b43aeb90371d0468d2831caf 100644 (file)
@@ -2663,6 +2663,15 @@ static int camss_of_parse_endpoint_node(struct device *dev,
        if (ret)
                return ret;
 
+       /*
+        * Most SoCs support both D-PHY and C-PHY standards, but currently only
+        * D-PHY is supported in the driver.
+        */
+       if (vep.bus_type != V4L2_MBUS_CSI2_DPHY) {
+               dev_err(dev, "Unsupported bus type %d\n", vep.bus_type);
+               return -EINVAL;
+       }
+
        csd->interface.csiphy_id = vep.base.port;
 
        mipi_csi2 = &vep.bus.mipi_csi2;