]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
pps: generators: tio: fix platform_set_drvdata()
authorRaag Jadav <raag.jadav@intel.com>
Tue, 18 Mar 2025 11:40:38 +0000 (17:10 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 15 Apr 2025 16:22:32 +0000 (18:22 +0200)
platform_set_drvdata() is setting a double pointer to struct pps_tio as
driver_data, which will point to the local stack of probe function instead
of intended data. Set driver_data correctly and fix illegal memory access
by its user.

 BUG: unable to handle page fault for address: ffffc9000117b738
 RIP: 0010:hrtimer_active+0x2b/0x60
 Call Trace:
  ? hrtimer_active+0x2b/0x60
  hrtimer_cancel+0x19/0x50
  pps_gen_tio_remove+0x1e/0x80 [pps_gen_tio]

Fixes: c89755d1111f ("pps: generators: Add PPS Generator TIO Driver")
Signed-off-by: Raag Jadav <raag.jadav@intel.com>
Acked-by: Rodolfo Giometti <giometti@enneenne.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20250318114038.2058677-1-raag.jadav@intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/pps/generators/pps_gen_tio.c

index 1d5ffe055463fcd0fe6ee1ba3cd74393f7334c04..de00a85bfafa2dd2dd822bf7dac20f67ddd42300 100644 (file)
@@ -230,7 +230,7 @@ static int pps_gen_tio_probe(struct platform_device *pdev)
        hrtimer_setup(&tio->timer, hrtimer_callback, CLOCK_REALTIME,
                      HRTIMER_MODE_ABS);
        spin_lock_init(&tio->lock);
-       platform_set_drvdata(pdev, &tio);
+       platform_set_drvdata(pdev, tio);
 
        return 0;
 }