]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
Avoid high privileges taint warning for QEMU session driver
authorDaniel P. Berrange <berrange@redhat.com>
Thu, 23 Jun 2011 10:40:24 +0000 (11:40 +0100)
committerDaniel P. Berrange <berrange@redhat.com>
Fri, 24 Jun 2011 11:15:10 +0000 (12:15 +0100)
The code emitting taint warnings was mistakenly thinking
that guests run from the QEMU session driver were tainted
for having high privileges. This is of course nonsense
since the session driver is always unprivileged

* src/qemu/qemu_domain.c: Don't warn for high privileges in
  non-privileged QEMU

src/qemu/qemu_domain.c

index fab316f0bd10b81dfe61a99dabb1ffb97276a50d..3af1c869342c695220a76a543e87d82cf2bfbad2 100644 (file)
@@ -788,9 +788,10 @@ void qemuDomainObjCheckTaint(struct qemud_driver *driver,
 {
     int i;
 
-    if (!driver->clearEmulatorCapabilities ||
-        driver->user == 0 ||
-        driver->group == 0)
+    if (driver->privileged &&
+        (!driver->clearEmulatorCapabilities ||
+         driver->user == 0 ||
+         driver->group == 0))
         qemuDomainObjTaint(driver, obj, VIR_DOMAIN_TAINT_HIGH_PRIVILEGES, logFD);
 
     if (obj->def->namespaceData) {