]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
media: Documentation: Document new v4l2_ctrl_handler_free() behaviour
authorSakari Ailus <sakari.ailus@linux.intel.com>
Thu, 19 Jun 2025 09:23:48 +0000 (12:23 +0300)
committerHans Verkuil <hverkuil@xs4all.nl>
Mon, 30 Jun 2025 06:47:41 +0000 (08:47 +0200)
v4l2_ctrl_handler_free() no longer resets the handler's error code.
Document it.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Documentation/driver-api/media/v4l2-controls.rst

index b2e91804829bded60c9655f4f51cd324caa6b2ac..fc04907589ab04aeac0c35dc7faaa23609b4f146 100644 (file)
@@ -110,6 +110,7 @@ For sub-device drivers:
 
        v4l2_ctrl_handler_free(&foo->ctrl_handler);
 
+:c:func:`v4l2_ctrl_handler_free` does not touch the handler's ``error`` field.
 
 2) Add controls:
 
@@ -191,12 +192,8 @@ These functions are typically called right after the
                        V4L2_CID_TEST_PATTERN, ARRAY_SIZE(test_pattern) - 1, 0,
                        0, test_pattern);
        ...
-       if (foo->ctrl_handler.error) {
-               int err = foo->ctrl_handler.error;
-
-               v4l2_ctrl_handler_free(&foo->ctrl_handler);
-               return err;
-       }
+       if (foo->ctrl_handler.error)
+               return v4l2_ctrl_handler_free(&foo->ctrl_handler);
 
 The :c:func:`v4l2_ctrl_new_std` function returns the v4l2_ctrl pointer to
 the new control, but if you do not need to access the pointer outside the