]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
output/ftp: Correct Coverity DEADCODE issue
authorJeff Lucovsky <jeff@lucovsky.org>
Fri, 10 Jul 2020 12:22:43 +0000 (08:22 -0400)
committerJeff Lucovsky <jeff@lucovsky.org>
Fri, 10 Jul 2020 12:22:43 +0000 (08:22 -0400)
This commit corrects the deadcode (CID 1465224) issue in
EveFTPLogCommand.

src/output-json-ftp.c

index 3b179957366f849ce2ab8a183e7765b5177fcc65..a30e1ff3874c66c16f7da8257dac91c9bb25bcb7 100644 (file)
@@ -67,7 +67,7 @@ static void EveFTPLogCommand(Flow *f, FTPTransaction *tx, JsonBuilder *jb)
         js_resplist = jb_new_array();
 
         if (unlikely(js_resplist == NULL)) {
-            goto fail;
+            return;
         }
     }
     jb_set_string(jb, "command", tx->command_descriptor->command_name);
@@ -143,13 +143,6 @@ static void EveFTPLogCommand(Flow *f, FTPTransaction *tx, JsonBuilder *jb)
     } else {
         JB_SET_STRING(jb, "reply_received", "no");
     }
-
-    return;
-
-fail:
-    if (js_resplist) {
-        jb_free(js_resplist);
-    }
 }