]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
bnxt_en: Use absolute target ns from ptp_clock_request
authorPavan Chebbi <pavan.chebbi@broadcom.com>
Mon, 4 May 2026 08:36:11 +0000 (14:06 +0530)
committerJakub Kicinski <kuba@kernel.org>
Wed, 6 May 2026 00:36:15 +0000 (17:36 -0700)
There is no need to calculate the target PHC cycles required
to make phase adjustment on the PPS OUT signal. This is because
the application supplies absolute n_sec value in the future and
is already the actual desired target value.

Remove the unnecessary code.

Fixes: 9e518f25802c ("bnxt_en: 1PPS functions to configure TSIO pins")
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Cc: Richard Cochran <richardcochran@gmail.com>
Signed-off-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Tested-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Link: https://patch.msgid.link/20260504083611.1383776-5-pavan.chebbi@broadcom.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c

index 53f336db4fcc0619c19d137ca4f5488e98336d7e..5d41dc1bc7820935cab0d4dacc5d460ba225928a 100644 (file)
@@ -419,31 +419,13 @@ void bnxt_ptp_reapply_pps(struct bnxt *bp)
        }
 }
 
-static int bnxt_get_target_cycles(struct bnxt_ptp_cfg *ptp, u64 target_ns,
-                                 u64 *cycles_delta)
-{
-       u64 cycles_now;
-       u64 nsec_now, nsec_delta;
-       int rc;
-
-       rc = bnxt_refclk_read(ptp->bp, NULL, &cycles_now);
-       if (rc)
-               return rc;
-
-       nsec_now = bnxt_timecounter_cyc2time(ptp, cycles_now);
-
-       nsec_delta = target_ns - nsec_now;
-       *cycles_delta = div64_u64(nsec_delta << ptp->cc.shift, ptp->cc.mult);
-       return 0;
-}
-
 static int bnxt_ptp_perout_cfg(struct bnxt_ptp_cfg *ptp,
                               struct ptp_clock_request *rq)
 {
        struct hwrm_func_ptp_cfg_input *req;
        struct bnxt *bp = ptp->bp;
        struct timespec64 ts;
-       u64 target_ns, delta;
+       u64 target_ns;
        u16 enables;
        int rc;
 
@@ -451,10 +433,6 @@ static int bnxt_ptp_perout_cfg(struct bnxt_ptp_cfg *ptp,
        ts.tv_nsec = rq->perout.start.nsec;
        target_ns = timespec64_to_ns(&ts);
 
-       rc = bnxt_get_target_cycles(ptp, target_ns, &delta);
-       if (rc)
-               return rc;
-
        rc = hwrm_req_init(bp, req, HWRM_FUNC_PTP_CFG);
        if (rc)
                return rc;
@@ -468,7 +446,10 @@ static int bnxt_ptp_perout_cfg(struct bnxt_ptp_cfg *ptp,
        req->ptp_freq_adj_dll_phase = 0;
        req->ptp_freq_adj_ext_period = cpu_to_le32(NSEC_PER_SEC);
        req->ptp_freq_adj_ext_up = 0;
-       req->ptp_freq_adj_ext_phase_lower = cpu_to_le32(delta);
+       req->ptp_freq_adj_ext_phase_lower =
+               cpu_to_le32(lower_32_bits(target_ns));
+       req->ptp_freq_adj_ext_phase_upper =
+               cpu_to_le32(upper_32_bits(target_ns));
 
        return hwrm_req_send(bp, req);
 }