]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
crypto: ixp4xx - dma_unmap the correct address
authorCorentin Labbe <clabbe@baylibre.com>
Wed, 5 May 2021 20:26:08 +0000 (20:26 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Jul 2021 14:59:30 +0000 (16:59 +0200)
[ Upstream commit 9395c58fdddd79cdd3882132cdd04e8ac7ad525f ]

Testing ixp4xx_crypto with CONFIG_DMA_API_DEBUG lead to the following error:
DMA-API: platform ixp4xx_crypto.0: device driver tries to free DMA memory it has not allocated [device address=0x0000000000000000] [size=24 bytes]

This is due to dma_unmap using the wrong address.

Fixes: 0d44dc59b2b4 ("crypto: ixp4xx - Fix handling of chained sg buffers")
Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/crypto/ixp4xx_crypto.c

index 8b0f17fc09fb5c16da0cc7bb85c4e95f63ab5015..9e330e93e3401a520ee83cc2dc41bc948d862d7b 100644 (file)
@@ -330,7 +330,7 @@ static void free_buf_chain(struct device *dev, struct buffer_desc *buf,
 
                buf1 = buf->next;
                phys1 = buf->phys_next;
-               dma_unmap_single(dev, buf->phys_next, buf->buf_len, buf->dir);
+               dma_unmap_single(dev, buf->phys_addr, buf->buf_len, buf->dir);
                dma_pool_free(buffer_pool, buf, phys);
                buf = buf1;
                phys = phys1;