BUG/MEDIUM: log: ensure that unique_id is properly initialized

Last memory poisonning patch immediately made this issue appear.
The unique_id field is released but not properly initialized. The
feature was introduced very recently, no backport is needed.

diff --git a/src/peers.c b/src/peers.c
index 182d71d23e2ef2d8e5b620b99e4da72afb8d8fe7..42018e13fea7319ad774138c4bc20d6f38a3ee18 100644 (file)
--- a/src/peers.c
+++ b/src/peers.c
@@ -1204,6 +1204,7 @@ static struct session *peer_session_create(struct peer *peer, struct peer_sessio
        s->srv_error = default_srv_error;
 
        s->uniq_id = 0;
+       s->unique_id = NULL;
 
        txn = &s->txn;
        /* Those variables will be checked and freed if non-NULL in

diff --git a/src/session.c b/src/session.c
index 862af58530cf24e7d7f8bee936cfc1c66b38a0ec..cd02da24d43dbd4ee3530f82d78555864db82521 100644 (file)
--- a/src/session.c
+++ b/src/session.c
@@ -97,6 +97,7 @@ int session_accept(struct listener *l, int cfd, struct sockaddr_storage *addr)
        LIST_ADDQ(&sessions, &s->list);
        LIST_INIT(&s->back_refs);
 
+       s->unique_id = NULL;
        s->term_trace = 0;
        s->si[0].addr.from = *addr;
        s->logs.accept_date = date; /* user-visible date for logging */