wifi: iwlwifi: mld: use FW_CHECK on bad ROC notification

If the firmware sends a ROC notification after the driver
cancelled it, we can get into this WARN_ON(). Don't do that,
use IWL_FW_CHECK() instead.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Tested-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Reviewed-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
Link: https://patch.msgid.link/20251019114304.48aff2c8922e.Ie27b21eb26b67c8010d13ce9590751cad417d1ad@changeid

diff --git a/drivers/net/wireless/intel/iwlwifi/mld/roc.c b/drivers/net/wireless/intel/iwlwifi/mld/roc.c
index 4136c98030d0428446fab9dcf0c5bef7d2120065..4e37a288471e5ac494ff00b7a50c27ec5c7bec07 100644 (file)
--- a/drivers/net/wireless/intel/iwlwifi/mld/roc.c
+++ b/drivers/net/wireless/intel/iwlwifi/mld/roc.c
@@ -231,7 +231,9 @@ void iwl_mld_handle_roc_notif(struct iwl_mld *mld,
        struct ieee80211_vif *vif;
 
        vif = iwl_mld_find_roc_vif(mld, activity);
-       if (WARN_ON(!vif))
+       if (IWL_FW_CHECK(mld, !vif,
+                        "unexpected ROC notif from FW for activity %d\n",
+                        activity))
                return;
 
        mld_vif = iwl_mld_vif_from_mac80211(vif);