]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
KVM: selftests: Use TEST_ASSERT_EQ() in test_vmx_nested_state()
authorYosry Ahmed <yosry.ahmed@linux.dev>
Fri, 21 Nov 2025 20:48:02 +0000 (20:48 +0000)
committerSean Christopherson <seanjc@google.com>
Thu, 8 Jan 2026 20:54:19 +0000 (12:54 -0800)
The assert messages do not add much value, so use TEST_ASSERT_EQ(),
which also nicely displays the addresses in hex. While at it, also
assert the values of state->flags.

Signed-off-by: Yosry Ahmed <yosry.ahmed@linux.dev>
Link: https://patch.msgid.link/20251121204803.991707-4-yosry.ahmed@linux.dev
Signed-off-by: Sean Christopherson <seanjc@google.com>
tools/testing/selftests/kvm/x86/vmx_set_nested_state_test.c

index 67a62a5a88951a11c969478f81da136672744e07..b59a8a17084d8e7fd7ab395516e582c489e64339 100644 (file)
@@ -241,8 +241,10 @@ void test_vmx_nested_state(struct kvm_vcpu *vcpu)
        TEST_ASSERT(state->size >= sizeof(*state) && state->size <= state_sz,
                    "Size must be between %ld and %d.  The size returned was %d.",
                    sizeof(*state), state_sz, state->size);
-       TEST_ASSERT(state->hdr.vmx.vmxon_pa == -1ull, "vmxon_pa must be -1ull.");
-       TEST_ASSERT(state->hdr.vmx.vmcs12_pa == -1ull, "vmcs_pa must be -1ull.");
+
+       TEST_ASSERT_EQ(state->hdr.vmx.vmxon_pa, -1ull);
+       TEST_ASSERT_EQ(state->hdr.vmx.vmcs12_pa, -1ull);
+       TEST_ASSERT_EQ(state->flags, 0);
 
        free(state);
 }