]> git.ipfire.org Git - thirdparty/hostap.git/commitdiff
hostapd: Fix Max SP Length derivation from QoS Info
authorSrinivasan B <srinivasanb@posedge.com>
Sat, 16 Feb 2013 09:15:13 +0000 (11:15 +0200)
committerJouni Malinen <j@w1.fi>
Sat, 16 Feb 2013 09:15:13 +0000 (11:15 +0200)
Hostapd provides QoS info of the STA (Service Period & AC mask) to the
kernel during wpa_driver_nl80211_sta_add call. Bit 5 and Bit 6 of QoS
info represents the Max SP length. Fix an issue in the code to fetch the
Max SP by shifting right the QoS info by value WMM_QOSINFO_STA_SP_SHIFT.
(operator ">" is replaced with ">>" operator).

Signed-off-by: Srinivasan <srinivasanb@posedge.com>
src/drivers/driver_nl80211.c

index bff0a512eba94790d242422931c786a8cb0e39a8..0803b160ee0588a59e9532472ce2caa9866539cb 100644 (file)
@@ -5883,7 +5883,7 @@ static int wpa_driver_nl80211_sta_add(void *priv,
                NLA_PUT_U8(wme, NL80211_STA_WME_UAPSD_QUEUES,
                                params->qosinfo & WMM_QOSINFO_STA_AC_MASK);
                NLA_PUT_U8(wme, NL80211_STA_WME_MAX_SP,
-                               (params->qosinfo > WMM_QOSINFO_STA_SP_SHIFT) &
+                               (params->qosinfo >> WMM_QOSINFO_STA_SP_SHIFT) &
                                WMM_QOSINFO_STA_SP_MASK);
                if (nla_put_nested(msg, NL80211_ATTR_STA_WME, wme) < 0)
                        goto nla_put_failure;