Fix critical on invalid element access

Fixes bug 590339.

diff --git a/vala/valaelementaccess.vala b/vala/valaelementaccess.vala
index c22131f7dbaf9a8e7cde0bf860e6c46d3c968fe9..4faf6d2803bfff108fb8d49f04fe715a6a059d52 100644 (file)
--- a/vala/valaelementaccess.vala
+++ b/vala/valaelementaccess.vala
@@ -104,11 +104,15 @@ public class Vala.ElementAccess : Expression {
 
                checked = true;
 
-               container.check (analyzer);
+               if (!container.check (analyzer)) {
+                       /* don't proceed if a child expression failed */
+                       error = true;
+                       return false;
+               }
 
                if (container.value_type == null) {
-                       /* don't proceed if a child expression failed */
                        error = true;
+                       Report.error (container.source_reference, "Invalid container expression");
                        return false;
                }