]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
media: pci: drop vb2_ops_wait_prepare/finish
authorHans Verkuil <hverkuil@xs4all.nl>
Mon, 14 Oct 2024 15:06:30 +0000 (17:06 +0200)
committerHans Verkuil <hverkuil@xs4all.nl>
Mon, 28 Oct 2024 08:19:53 +0000 (09:19 +0100)
Since commit 88785982a19d ("media: vb2: use lock if wait_prepare/finish
are NULL") it is no longer needed to set the wait_prepare/finish
vb2_ops callbacks as long as the lock field in vb2_queue is set.

Since the vb2_ops_wait_prepare/finish callbacks already rely on that field,
we can safely drop these callbacks.

This simplifies the code and this is a step towards the goal of deleting
these callbacks.

Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
29 files changed:
drivers/media/pci/bt8xx/bttv-driver.c
drivers/media/pci/bt8xx/bttv-vbi.c
drivers/media/pci/cobalt/cobalt-v4l2.c
drivers/media/pci/cx18/cx18-streams.c
drivers/media/pci/cx23885/cx23885-417.c
drivers/media/pci/cx23885/cx23885-dvb.c
drivers/media/pci/cx23885/cx23885-vbi.c
drivers/media/pci/cx23885/cx23885-video.c
drivers/media/pci/cx25821/cx25821-video.c
drivers/media/pci/cx88/cx88-blackbird.c
drivers/media/pci/cx88/cx88-dvb.c
drivers/media/pci/cx88/cx88-vbi.c
drivers/media/pci/cx88/cx88-video.c
drivers/media/pci/dt3155/dt3155.c
drivers/media/pci/intel/ipu3/ipu3-cio2.c
drivers/media/pci/intel/ipu6/ipu6-isys-queue.c
drivers/media/pci/mgb4/mgb4_vin.c
drivers/media/pci/mgb4/mgb4_vout.c
drivers/media/pci/saa7134/saa7134-empress.c
drivers/media/pci/saa7134/saa7134-ts.c
drivers/media/pci/saa7134/saa7134-vbi.c
drivers/media/pci/saa7134/saa7134-video.c
drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c
drivers/media/pci/solo6x10/solo6x10-v4l2.c
drivers/media/pci/sta2x11/sta2x11_vip.c
drivers/media/pci/tw5864/tw5864-video.c
drivers/media/pci/tw68/tw68-video.c
drivers/media/pci/tw686x/tw686x-video.c
drivers/media/pci/zoran/zoran_driver.c

index 511f013cc33873ecc0a5ee4adfa4eb0727f38022..2782832f5eb8f272cf9acf29d7b4c31620c99227 100644 (file)
@@ -1584,8 +1584,6 @@ static const struct vb2_ops bttv_video_qops = {
        .buf_cleanup    = buf_cleanup,
        .start_streaming = start_streaming,
        .stop_streaming = stop_streaming,
-       .wait_prepare   = vb2_ops_wait_prepare,
-       .wait_finish    = vb2_ops_wait_finish,
 };
 
 static void radio_enable(struct bttv *btv)
index e489a3acb4b98afa17036c3a85514c40031f40e5..a71440611e46eccfc442a7f9100f803d9d875201 100644 (file)
@@ -170,8 +170,6 @@ const struct vb2_ops bttv_vbi_qops = {
        .buf_cleanup    = buf_cleanup_vbi,
        .start_streaming = start_streaming_vbi,
        .stop_streaming = stop_streaming_vbi,
-       .wait_prepare   = vb2_ops_wait_prepare,
-       .wait_finish    = vb2_ops_wait_finish,
 };
 
 /* ----------------------------------------------------------------------- */
index d4d7b264c965a3a6a7c76e23567b0c18deb742d3..ae82427e3479bb316dc310bb11837aad05ffaf9c 100644 (file)
@@ -424,8 +424,6 @@ static const struct vb2_ops cobalt_qops = {
        .buf_queue = cobalt_buf_queue,
        .start_streaming = cobalt_start_streaming,
        .stop_streaming = cobalt_stop_streaming,
-       .wait_prepare = vb2_ops_wait_prepare,
-       .wait_finish = vb2_ops_wait_finish,
 };
 
 /* V4L2 ioctls */
index acc6418db4254ab00eb1b70ebdce30799e85e503..42d6f7b90ede3045b9c5612a35ce8dbee2551282 100644 (file)
@@ -229,8 +229,6 @@ static const struct vb2_ops cx18_vb2_qops = {
        .buf_prepare            = cx18_buf_prepare,
        .start_streaming        = cx18_start_streaming,
        .stop_streaming         = cx18_stop_streaming,
-       .wait_prepare           = vb2_ops_wait_prepare,
-       .wait_finish            = vb2_ops_wait_finish,
 };
 
 static int cx18_stream_init(struct cx18 *cx, int type)
index fdb96f80c03649f9ce1f5acac8f4b9b3e54b9df1..219937a153b3aed206091579fffbd07840ca0c3a 100644 (file)
@@ -1210,8 +1210,6 @@ static const struct vb2_ops cx23885_qops = {
        .buf_prepare  = buffer_prepare,
        .buf_finish = buffer_finish,
        .buf_queue    = buffer_queue,
-       .wait_prepare = vb2_ops_wait_prepare,
-       .wait_finish = vb2_ops_wait_finish,
        .start_streaming = cx23885_start_streaming,
        .stop_streaming = cx23885_stop_streaming,
 };
index 3d01cdc4c7f3d7d379a63d9fde4d2ded73d41972..05a7859cbe5795bdb7d54510fe617f48ab486986 100644 (file)
@@ -170,8 +170,6 @@ static const struct vb2_ops dvb_qops = {
        .buf_prepare  = buffer_prepare,
        .buf_finish = buffer_finish,
        .buf_queue    = buffer_queue,
-       .wait_prepare = vb2_ops_wait_prepare,
-       .wait_finish = vb2_ops_wait_finish,
        .start_streaming = cx23885_start_streaming,
        .stop_streaming = cx23885_stop_streaming,
 };
index 4bdd2bea3713e1dc0fd630dedf345d87c9a8632f..40817cc52fc1ee256be86319638d0d26116e51c0 100644 (file)
@@ -249,8 +249,6 @@ const struct vb2_ops cx23885_vbi_qops = {
        .buf_prepare  = buffer_prepare,
        .buf_finish = buffer_finish,
        .buf_queue    = buffer_queue,
-       .wait_prepare = vb2_ops_wait_prepare,
-       .wait_finish = vb2_ops_wait_finish,
        .start_streaming = cx23885_start_streaming,
        .stop_streaming = cx23885_stop_streaming,
 };
index 7d4a409c433e2a8c909323542e6f917bd27cfb64..35d58328db563992fa1332e3e96427749eaf7ed8 100644 (file)
@@ -519,8 +519,6 @@ static const struct vb2_ops cx23885_video_qops = {
        .buf_prepare  = buffer_prepare,
        .buf_finish = buffer_finish,
        .buf_queue    = buffer_queue,
-       .wait_prepare = vb2_ops_wait_prepare,
-       .wait_finish = vb2_ops_wait_finish,
        .start_streaming = cx23885_start_streaming,
        .stop_streaming = cx23885_stop_streaming,
 };
index 0bee4b728a6014817d74fe243dbf9ef3c2da1524..84aa1209e7171ecc541a764fea064e031ce2bb6e 100644 (file)
@@ -295,8 +295,6 @@ static const struct vb2_ops cx25821_video_qops = {
        .buf_prepare  = cx25821_buffer_prepare,
        .buf_finish = cx25821_buffer_finish,
        .buf_queue    = cx25821_buffer_queue,
-       .wait_prepare = vb2_ops_wait_prepare,
-       .wait_finish = vb2_ops_wait_finish,
        .start_streaming = cx25821_start_streaming,
        .stop_streaming = cx25821_stop_streaming,
 };
index d55df8fdb3b604400495021033b3e57406f982e1..13b8cc46835b2cb5a84405cdb7fa21d35675f552 100644 (file)
@@ -781,8 +781,6 @@ static const struct vb2_ops blackbird_qops = {
        .buf_prepare  = buffer_prepare,
        .buf_finish = buffer_finish,
        .buf_queue    = buffer_queue,
-       .wait_prepare = vb2_ops_wait_prepare,
-       .wait_finish = vb2_ops_wait_finish,
        .start_streaming = start_streaming,
        .stop_streaming = stop_streaming,
 };
index b33b3a5e32ec6479d96af4558d200be6122572f9..c9cfceed2f1b42fc5a9c2c97900b7e1d638226c8 100644 (file)
@@ -152,8 +152,6 @@ static const struct vb2_ops dvb_qops = {
        .buf_prepare  = buffer_prepare,
        .buf_finish = buffer_finish,
        .buf_queue    = buffer_queue,
-       .wait_prepare = vb2_ops_wait_prepare,
-       .wait_finish = vb2_ops_wait_finish,
        .start_streaming = start_streaming,
        .stop_streaming = stop_streaming,
 };
index 469aeaa725ad9259122f407edf71006f5e324b4d..e3e379e6f6207b6ebf08327263d7087f5122d236 100644 (file)
@@ -228,8 +228,6 @@ const struct vb2_ops cx8800_vbi_qops = {
        .buf_prepare  = buffer_prepare,
        .buf_finish = buffer_finish,
        .buf_queue    = buffer_queue,
-       .wait_prepare = vb2_ops_wait_prepare,
-       .wait_finish = vb2_ops_wait_finish,
        .start_streaming = start_streaming,
        .stop_streaming = stop_streaming,
 };
index cefb6b25e92172b188b9f4f699492eaa31cf2b0b..0c87327689d3f669241bfc11ca07f7210f603a36 100644 (file)
@@ -562,8 +562,6 @@ static const struct vb2_ops cx8800_video_qops = {
        .buf_prepare  = buffer_prepare,
        .buf_finish = buffer_finish,
        .buf_queue    = buffer_queue,
-       .wait_prepare = vb2_ops_wait_prepare,
-       .wait_finish = vb2_ops_wait_finish,
        .start_streaming = start_streaming,
        .stop_streaming = stop_streaming,
 };
index dff853e73fdc8ef66f18cd7f27e017346850c6d8..7bddcbba4cf1ba2998afbfe1e961ad89a303f1c2 100644 (file)
@@ -222,8 +222,6 @@ static void dt3155_buf_queue(struct vb2_buffer *vb)
 
 static const struct vb2_ops q_ops = {
        .queue_setup = dt3155_queue_setup,
-       .wait_prepare = vb2_ops_wait_prepare,
-       .wait_finish = vb2_ops_wait_finish,
        .buf_prepare = dt3155_buf_prepare,
        .start_streaming = dt3155_start_streaming,
        .stop_streaming = dt3155_stop_streaming,
index 81ec8630453b7a1240528f1d36182d0928aded09..4e98f432ed557393c83dbbe404b6d5e6d87fd106 100644 (file)
@@ -1045,8 +1045,6 @@ static const struct vb2_ops cio2_vb2_ops = {
        .queue_setup = cio2_vb2_queue_setup,
        .start_streaming = cio2_vb2_start_streaming,
        .stop_streaming = cio2_vb2_stop_streaming,
-       .wait_prepare = vb2_ops_wait_prepare,
-       .wait_finish = vb2_ops_wait_finish,
 };
 
 /**************** V4L2 interface ****************/
index 03dbb0e0ea7957970667cef31f668a807b30455a..4e15dd75cf865559893eea55360e8224f78fbc7c 100644 (file)
@@ -767,8 +767,6 @@ void ipu6_isys_queue_buf_ready(struct ipu6_isys_stream *stream,
 
 static const struct vb2_ops ipu6_isys_queue_ops = {
        .queue_setup = queue_setup,
-       .wait_prepare = vb2_ops_wait_prepare,
-       .wait_finish = vb2_ops_wait_finish,
        .buf_prepare = ipu6_isys_buf_prepare,
        .start_streaming = start_streaming,
        .stop_streaming = stop_streaming,
index 185fb28226b60c3253f64d78e945172c6321ac33..e34d02d1e943db98578765562e99d79776fe52a0 100644 (file)
@@ -304,8 +304,6 @@ static const struct vb2_ops queue_ops = {
        .buf_queue = buffer_queue,
        .start_streaming = start_streaming,
        .stop_streaming = stop_streaming,
-       .wait_prepare = vb2_ops_wait_prepare,
-       .wait_finish = vb2_ops_wait_finish
 };
 
 static int fh_open(struct file *file)
index 133110aac68808fa956ae7da8cb2e6bd27cf7447..6b2791e29de15e5124c5a05ed5bf1a9e2668f6d5 100644 (file)
@@ -230,8 +230,6 @@ static const struct vb2_ops queue_ops = {
        .buf_queue = buffer_queue,
        .start_streaming = start_streaming,
        .stop_streaming = stop_streaming,
-       .wait_prepare = vb2_ops_wait_prepare,
-       .wait_finish = vb2_ops_wait_finish
 };
 
 static int vidioc_querycap(struct file *file, void *priv,
index bbf480ab31ca7728934821faf33b734d894b9a8c..8c4f70e4177d1836ad685be851df63b234674c40 100644 (file)
@@ -78,8 +78,6 @@ static const struct vb2_ops saa7134_empress_qops = {
        .buf_init       = saa7134_ts_buffer_init,
        .buf_prepare    = saa7134_ts_buffer_prepare,
        .buf_queue      = saa7134_vb2_buffer_queue,
-       .wait_prepare   = vb2_ops_wait_prepare,
-       .wait_finish    = vb2_ops_wait_finish,
        .start_streaming = start_streaming,
        .stop_streaming = stop_streaming,
 };
index 437dbe5e75e2975a370a99f14f9aeb9fb5658b96..ec699ea14799427a8c0d0b6318fa30d94dc061ea 100644 (file)
@@ -166,8 +166,6 @@ struct vb2_ops saa7134_ts_qops = {
        .buf_init       = saa7134_ts_buffer_init,
        .buf_prepare    = saa7134_ts_buffer_prepare,
        .buf_queue      = saa7134_vb2_buffer_queue,
-       .wait_prepare   = vb2_ops_wait_prepare,
-       .wait_finish    = vb2_ops_wait_finish,
        .stop_streaming = saa7134_ts_stop_streaming,
 };
 EXPORT_SYMBOL_GPL(saa7134_ts_qops);
index 3e773690468bdb935d0a2ada46ef9a7f9da23e8d..efa6e4fa423aa9cfed5556bb7f19832fa18811e2 100644 (file)
@@ -161,8 +161,6 @@ const struct vb2_ops saa7134_vbi_qops = {
        .buf_init       = buffer_init,
        .buf_prepare    = buffer_prepare,
        .buf_queue      = saa7134_vb2_buffer_queue,
-       .wait_prepare   = vb2_ops_wait_prepare,
-       .wait_finish    = vb2_ops_wait_finish,
        .start_streaming = saa7134_vb2_start_streaming,
        .stop_streaming = saa7134_vb2_stop_streaming,
 };
index 56b4481a40e6125fa8534a85e56031186a190e8e..43e7b006eb596740771cf893d8fda39df0e4aff4 100644 (file)
@@ -844,8 +844,6 @@ static const struct vb2_ops vb2_qops = {
        .buf_init       = buffer_init,
        .buf_prepare    = buffer_prepare,
        .buf_queue      = saa7134_vb2_buffer_queue,
-       .wait_prepare   = vb2_ops_wait_prepare,
-       .wait_finish    = vb2_ops_wait_finish,
        .start_streaming = saa7134_vb2_start_streaming,
        .stop_streaming = saa7134_vb2_stop_streaming,
 };
index 0adf3d80f248ed3511509e5a571f1226cac62866..5ee59b3844cc3dc4ae42c255a0ea3e624c605a1d 100644 (file)
@@ -756,8 +756,6 @@ static const struct vb2_ops solo_enc_video_qops = {
        .buf_finish     = solo_enc_buf_finish,
        .start_streaming = solo_enc_start_streaming,
        .stop_streaming = solo_enc_stop_streaming,
-       .wait_prepare   = vb2_ops_wait_prepare,
-       .wait_finish    = vb2_ops_wait_finish,
 };
 
 static int solo_enc_querycap(struct file *file, void  *priv,
index e18cc41fca83b2b5293dc4d654c96a5ee86a6993..35715b21dbdffc80de68990b88836700816e7cb6 100644 (file)
@@ -365,8 +365,6 @@ static const struct vb2_ops solo_video_qops = {
        .buf_queue      = solo_buf_queue,
        .start_streaming = solo_start_streaming,
        .stop_streaming = solo_stop_streaming,
-       .wait_prepare   = vb2_ops_wait_prepare,
-       .wait_finish    = vb2_ops_wait_finish,
 };
 
 static int solo_querycap(struct file *file, void  *priv,
index 364ce9e5701827de4d7b92cac104fa9d0fcb8869..3049bad20f142dbfdf6bbd47699c50f75cb10f72 100644 (file)
@@ -372,8 +372,6 @@ static const struct vb2_ops vip_video_qops = {
        .buf_queue              = buffer_queue,
        .start_streaming        = start_streaming,
        .stop_streaming         = stop_streaming,
-       .wait_prepare           = vb2_ops_wait_prepare,
-       .wait_finish            = vb2_ops_wait_finish,
 };
 
 
index 4f35c159efe5a39be8c674a8d21b4e58437849f9..0a08708e52b08283074db66611969312762182a8 100644 (file)
@@ -471,8 +471,6 @@ static const struct vb2_ops tw5864_video_qops = {
        .buf_queue = tw5864_buf_queue,
        .start_streaming = tw5864_start_streaming,
        .stop_streaming = tw5864_stop_streaming,
-       .wait_prepare = vb2_ops_wait_prepare,
-       .wait_finish = vb2_ops_wait_finish,
 };
 
 static int tw5864_s_ctrl(struct v4l2_ctrl *ctrl)
index cdf5d733b863e46186e3a02f9f3e489ba1b62c5f..77773dec48b83ac997fcbbb4dc83e55861a899eb 100644 (file)
@@ -524,8 +524,6 @@ static const struct vb2_ops tw68_video_qops = {
        .buf_finish     = tw68_buf_finish,
        .start_streaming = tw68_start_streaming,
        .stop_streaming = tw68_stop_streaming,
-       .wait_prepare   = vb2_ops_wait_prepare,
-       .wait_finish    = vb2_ops_wait_finish,
 };
 
 /* ------------------------------------------------------------------ */
index 63be95fce83d132718ed94a20865fc337b701cc7..785dd797d921b515ead7b500edd01a4ac0618e6d 100644 (file)
@@ -579,8 +579,6 @@ static const struct vb2_ops tw686x_video_qops = {
        .buf_prepare            = tw686x_buf_prepare,
        .start_streaming        = tw686x_start_streaming,
        .stop_streaming         = tw686x_stop_streaming,
-       .wait_prepare           = vb2_ops_wait_prepare,
-       .wait_finish            = vb2_ops_wait_finish,
 };
 
 static int tw686x_s_ctrl(struct v4l2_ctrl *ctrl)
index 5c05e64c71a905a2900b3e7feeea50672394881a..f42f596d3e6295e31e3b33cd83c5f7243911bd30 100644 (file)
@@ -950,8 +950,6 @@ static const struct vb2_ops zr_video_qops = {
        .buf_prepare            = zr_vb2_prepare,
        .start_streaming        = zr_vb2_start_streaming,
        .stop_streaming         = zr_vb2_stop_streaming,
-       .wait_prepare           = vb2_ops_wait_prepare,
-       .wait_finish            = vb2_ops_wait_finish,
 };
 
 int zoran_queue_init(struct zoran *zr, struct vb2_queue *vq, int dir)