]> git.ipfire.org Git - thirdparty/libcgroup.git/commitdiff
wrapper: fix missing unlock() in cgroup_add_all_controllers()
authorKamalesh Babulal <kamalesh.babulal@oracle.com>
Thu, 15 Jun 2023 09:54:06 +0000 (15:24 +0530)
committerTom Hromatka <tom.hromatka@oracle.com>
Thu, 15 Jun 2023 14:02:05 +0000 (08:02 -0600)
Fix missing unlock(), reported by Coverity tool:

CID 313906 (#1 of 1): Missing unlock (LOCK)6. missing_unlock: Returning
without unlocking cg_mount_table_lock

add the missing pthread_rwlock_unlock() in the error path of the
cgroup_add_all_controllers()

Fixes: 4124f4d6853a ("wrapper: Add cgroup v2 support to cgroup_add_all_controllers()")
Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
src/wrapper.c

index 1ce74e77bc0332e3bb9a3963aba6396f0df7ee19..547d5054d0c2cd30c27a150671aa9d81892df704 100644 (file)
@@ -136,6 +136,7 @@ int cgroup_add_all_controllers(struct cgroup *cgroup)
 
                pthread_rwlock_rdlock(&cg_mount_table_lock);
                if (strlen(cg_cgroup_v2_mount_path) == 0) {
+                       pthread_rwlock_unlock(&cg_mount_table_lock);
                        ret = ECGOTHER;
                        goto out;
                }