]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
gh-142595: add type check for namedtuple call during decimal initialization (GH-142608)
authorSergey B Kirpichev <skirpichev@gmail.com>
Fri, 12 Dec 2025 10:47:45 +0000 (13:47 +0300)
committerGitHub <noreply@github.com>
Fri, 12 Dec 2025 10:47:45 +0000 (11:47 +0100)
Misc/NEWS.d/next/Library/2025-12-12-02-56-26.gh-issue-142595.wHvTqq.rst [new file with mode: 0644]
Modules/_decimal/_decimal.c

diff --git a/Misc/NEWS.d/next/Library/2025-12-12-02-56-26.gh-issue-142595.wHvTqq.rst b/Misc/NEWS.d/next/Library/2025-12-12-02-56-26.gh-issue-142595.wHvTqq.rst
new file mode 100644 (file)
index 0000000..987e1ae
--- /dev/null
@@ -0,0 +1,2 @@
+Added type check during initialization of the :mod:`decimal` module to
+prevent a crash in case of broken stdlib.  Patch by Sergey B Kirpichev.
index 0484d9896a1c17c7d33d67491344c8bfaaf097f3..6ed8c0f3beb27767c9a03552c3d442d10cf01f12 100644 (file)
@@ -7753,10 +7753,14 @@ _decimal_exec(PyObject *m)
 
     /* DecimalTuple */
     ASSIGN_PTR(collections, PyImport_ImportModule("collections"));
-    ASSIGN_PTR(state->DecimalTuple, (PyTypeObject *)PyObject_CallMethod(collections,
-                                 "namedtuple", "(ss)", "DecimalTuple",
-                                 "sign digits exponent"));
-
+    obj = PyObject_CallMethod(collections, "namedtuple", "(ss)", "DecimalTuple",
+                              "sign digits exponent");
+    if (!PyType_Check(obj)) {
+        PyErr_SetString(PyExc_TypeError,
+                        "type is expected from namedtuple call");
+        goto error;
+    }
+    ASSIGN_PTR(state->DecimalTuple, (PyTypeObject *)obj);
     ASSIGN_PTR(obj, PyUnicode_FromString("decimal"));
     CHECK_INT(PyDict_SetItemString(state->DecimalTuple->tp_dict, "__module__", obj));
     Py_CLEAR(obj);