]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ASoC: tlv320adcx140: fix null pointer
authorEmil Svendsen <emas@bang-olufsen.dk>
Tue, 13 Jan 2026 10:58:45 +0000 (11:58 +0100)
committerMark Brown <broonie@kernel.org>
Wed, 14 Jan 2026 13:35:30 +0000 (13:35 +0000)
The "snd_soc_component" in "adcx140_priv" was only used once but never
set. It was only used for reaching "dev" which is already present in
"adcx140_priv".

Fixes: 4e82971f7b55 ("ASoC: tlv320adcx140: Add a new kcontrol")
Signed-off-by: Emil Svendsen <emas@bang-olufsen.dk>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Link: https://patch.msgid.link/20260113-sound-soc-codecs-tvl320adcx140-v4-2-8f7ecec525c8@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/tlv320adcx140.c

index 75e1007012a48a569586bc2896400e79ddce1c71..3fb1b6251e6f8b361e8f82ce6381a7e8cfcd1935 100644 (file)
@@ -23,7 +23,6 @@
 #include "tlv320adcx140.h"
 
 struct adcx140_priv {
-       struct snd_soc_component *component;
        struct regulator *supply_areg;
        struct gpio_desc *gpio_reset;
        struct regmap *regmap;
@@ -699,7 +698,6 @@ static void adcx140_pwr_ctrl(struct adcx140_priv *adcx140, bool power_state)
 {
        int pwr_ctrl = 0;
        int ret = 0;
-       struct snd_soc_component *component = adcx140->component;
 
        if (power_state)
                pwr_ctrl = ADCX140_PWR_CFG_ADC_PDZ | ADCX140_PWR_CFG_PLL_PDZ;
@@ -711,7 +709,7 @@ static void adcx140_pwr_ctrl(struct adcx140_priv *adcx140, bool power_state)
                ret = regmap_write(adcx140->regmap, ADCX140_PHASE_CALIB,
                        adcx140->phase_calib_on ? 0x00 : 0x40);
                if (ret)
-                       dev_err(component->dev, "%s: register write error %d\n",
+                       dev_err(adcx140->dev, "%s: register write error %d\n",
                                __func__, ret);
        }