phy: rockchip: naneng-combphy: Fix PCIe L1ss support RK3562

When PCIe link enters L1 PM substates, the PHY will turn off its
PLL for power-saving. However, it turns off the PLL too fast which
leads the PHY to be broken. According to the PHY document, we need
to delay PLL turnoff time.

Fixes: f13bff25161b ("phy: rockchip-naneng-combo: Support rk3562")
Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://patch.msgid.link/1763459526-35004-2-git-send-email-shawn.lin@rock-chips.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>

diff --git a/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c b/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c
index e303bec8a996fcfc9c7321c3a10a8192e97d6b3a..7f8fc8e6d48905f4e198ae349b485a067dc98c54 100644 (file)
--- a/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c
+++ b/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c
@@ -106,6 +106,10 @@
 #define RK3568_PHYREG18                                0x44
 #define RK3568_PHYREG18_PLL_LOOP               0x32
 
+#define RK3568_PHYREG30                                0x74
+#define RK3568_PHYREG30_GATE_TX_PCK_SEL         BIT(7)
+#define RK3568_PHYREG30_GATE_TX_PCK_DLY_PLL_OFF BIT(7)
+
 #define RK3568_PHYREG32                                0x7C
 #define RK3568_PHYREG32_SSC_MASK               GENMASK(7, 4)
 #define RK3568_PHYREG32_SSC_DIR_MASK           GENMASK(5, 4)
@@ -664,6 +668,10 @@ static int rk3562_combphy_cfg(struct rockchip_combphy_priv *priv)
        case REF_CLOCK_100MHz:
                rockchip_combphy_param_write(priv->phy_grf, &cfg->pipe_clk_100m, true);
                if (priv->type == PHY_TYPE_PCIE) {
+                       /* Gate_tx_pck_sel length select for L1ss support */
+                       rockchip_combphy_updatel(priv, RK3568_PHYREG30_GATE_TX_PCK_SEL,
+                                                RK3568_PHYREG30_GATE_TX_PCK_DLY_PLL_OFF,
+                                                RK3568_PHYREG30);
                        /* PLL KVCO tuning fine */
                        val = FIELD_PREP(RK3568_PHYREG33_PLL_KVCO_MASK,
                                         RK3568_PHYREG33_PLL_KVCO_VALUE);